Skip to content

Fix ml_base dependency#37721

Open
Abacn wants to merge 2 commits intoapache:masterfrom
Abacn:set-absl-py
Open

Fix ml_base dependency#37721
Abacn wants to merge 2 commits intoapache:masterfrom
Abacn:set-absl-py

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Feb 26, 2026

Fix #32603

Apparently this specific test trying to install many packages at one time : apache-beam[gcp,test,aws,azure,dataframe,ml_test,yaml] overwhelmed pip.

Make installGcpTest task installs stardard extensions first then extra. PyPI is still running into the scenario that downloading many versions of some dependency, but less than before.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a dependency compatibility issue within the Python SDK's machine learning components. It explicitly adds absl-py with a minimum version requirement to the tensorflow, ml_cpu, and ml_gpu extra dependency groups. This change is crucial for ensuring these components function correctly with Python 3.10 and later versions by resolving conflicts with older absl-py versions that are not compatible.

Highlights

  • Dependency Update: Added absl-py>=0.12.0 as an explicit dependency for the tensorflow extra in sdks/python/setup.py.
  • ML CPU Dependencies: Included absl-py>=0.12.0 in the ml_cpu extra dependency group to ensure compatibility.
  • ML GPU Dependencies: Added absl-py>=0.12.0 to the ml_gpu extra dependency group.
  • Python 3.10+ Compatibility: The absl-py dependency was added to resolve transient dependency issues with lower versions that are not compatible with Python 3.10 and newer.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/python/setup.py
    • Added absl-py>=0.12.0 to the tensorflow extra dependency list.
    • Added absl-py>=0.12.0 to the ml_cpu extra dependency list.
    • Added absl-py>=0.12.0 to the ml_gpu extra dependency list.
Activity
  • No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Abacn Abacn force-pushed the set-absl-py branch 2 times, most recently from 02653fd to b8aaa1b Compare February 26, 2026 19:41
@github-actions github-actions bot added the build label Feb 26, 2026
@Abacn Abacn force-pushed the set-absl-py branch 2 times, most recently from d6f5fd1 to 2e6e7d0 Compare February 27, 2026 01:19
@Abacn
Copy link
Contributor Author

Abacn commented Feb 27, 2026

Tests passed: https://github.com/apache/beam/actions/runs/22468600600/job/65080284789?pr=37721

even though there are (pre-existing) dependency conflicts

tox 4.46.3 requires cachetools>=7.0.1, but you have cachetools 6.2.6 which is incompatible.

@Abacn
Copy link
Contributor Author

Abacn commented Feb 27, 2026

R: @tvalentyn @aIbrahiim

this is a narrower scoped change than #37685

@Abacn Abacn marked this pull request as ready for review February 27, 2026 02:17
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PreCommit YAML Xlang Direct job is perma-red

2 participants