Resolves pytest on ubuntu latest by installing pymilvus

[aIbrahiim]

Fixes: PreCommit Python Coverage
Successful run: https://github.com/aIbrahiim/beam/actions/runs/22364377513

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @aIbrahiim, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a pytest failure occurring on Ubuntu by modifying the tox.ini configuration. The change ensures that the pymilvus dependency is properly included in the test environment, which is crucial for successful test execution and maintaining the stability of the continuous integration pipeline.

Highlights

• Pytest Dependency Resolution: Added milvus to the extras list within sdks/python/tox.ini to ensure the pymilvus dependency is installed during pytest execution, resolving test failures on Ubuntu.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• sdks/python/tox.ini
  • Added milvus to the extras list to include pymilvus as a test dependency.

Activity

• A successful CI run was reported by the author, indicating the fix resolves the identified issue.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Assigning reviewers:

R: @claudevdm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[claudevdm]

@aIbrahiim can you link the failing test? I dont think milvus being missing should cause issues since the tests should just get skippedin that case

[aIbrahiim]

@claudevdm The tests are being skipped, but its happening at collection time rather than execution time which cause pytest to fail

The two failing tests are:
sdks/python/apache_beam/ml/rag/enrichment/milvus_search_it_test.py
sdks/python/apache_beam/ml/rag/ingestion/milvus_search_it_test.py

And heres my investigation: The ubuntu latest runner runs with -m require_docker_in_docker to execute only these two Milvus tests but both files import pymilvus at the module levels and when that import fails they raise unittest.SkipTest immediately before pytest can even collect the tests and since these are the only two files marked with require_docker_in_docker the pytest ends up collecting zero tests and returns exit code 5 "no tests collected" so the run_pytest.sh script treats this as a failure so i think if the tests were skipped during execution after being collected that would be fine but they are skipped during collection so pytest never sees any runnable tests

[Abacn]

The tests failing on master branch is https://github.com/apache/beam/actions/workflows/beam_PreCommit_Python_Coverage.yml?query=event%3Aschedule

caused by #37668

Now I think we should exclude milvus tests from Python Coverage, per the comment above:

> # NOTE: we could add ml_test to increase the collected code coverage metrics, but it would make the suite slower.

The ubuntu latest runner runs with -m require_docker_in_docker to execute only these two Milvus tests

I see. So we still need this coverage.

This should now be covered by

https://github.com/apache/beam/actions/workflows/beam_PreCommit_Python_ML.yml

after #37668, as it's now installed in ml_test extension.

I think we can just remove the matrix for DinD tests in https://github.com/apache/beam/actions/workflows/beam_PreCommit_Python_Coverage.yml for now.

[claudevdm]

Sorry I must have misclicked. Didnt mean to close