Skip to content

Comments

Fix PostCommit Python Xlang Gcp Direct job#37646

Merged
Abacn merged 1 commit intomasterfrom
fix-pc-python-xlang-gcp-direct
Feb 19, 2026
Merged

Fix PostCommit Python Xlang Gcp Direct job#37646
Abacn merged 1 commit intomasterfrom
fix-pc-python-xlang-gcp-direct

Conversation

@Amar3tto
Copy link
Collaborator

@Amar3tto Amar3tto commented Feb 19, 2026

Fixes #35285
Successful run: https://github.com/apache/beam/actions/runs/22182727355


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Amar3tto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue causing the PostCommit Python Xlang GCP Direct job to fail. The fix involves updating a parameter name from chunk_to_dict_fn to embeddable_to_dict_fn in the BigQuery vector ingestion functionality within Apache Beam's ML components. This ensures the job executes correctly and maintains the integrity of the data ingestion pipeline.

Highlights

  • Parameter Renaming: The chunk_to_dict_fn parameter has been renamed to embeddable_to_dict_fn within the SchemaConfig for BigQuery vector ingestion components.
  • Post-Commit Job Fix: This change resolves a failure in the PostCommit Python Xlang GCP Direct job by correcting the parameter name used in the BigQuery vector ingestion process.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • examples/notebooks/beam-ml/bigquery_vector_ingestion_and_search.ipynb
    • Updated the parameter name for dictionary conversion in the BigQuery vector ingestion notebook.
  • sdks/python/apache_beam/ml/rag/ingestion/bigquery_it_test.py
    • Corrected the parameter name for dictionary conversion in the BigQuery ingestion integration test.
Activity
  • A successful run of the GitHub Actions workflow has been linked, verifying the fix.
  • The pull request description includes a standard contributor checklist.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Amar3tto
Copy link
Collaborator Author

Failing checks are unrelated to this PR (#31285 and #35198)

@Abacn Abacn mentioned this pull request Feb 19, 2026
3 tasks
@Abacn Abacn merged commit 120ceab into master Feb 19, 2026
123 of 132 checks passed
@damccorm damccorm deleted the fix-pc-python-xlang-gcp-direct branch February 19, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit Python Xlang Gcp Direct job is flaky

2 participants