Fix trigger example write append#37409
Fix trigger example write append#37409RushabhRatnaparkhi wants to merge 3 commits intoapache:masterfrom
Conversation
Summary of ChangesHello @RushabhRatnaparkhi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a BigQuery write failure in the TriggerExample cookbook example when running on Dataflow. The example runs four separate pipelines with different trigger configurations that all write to the same BigQuery table. Previously, the default WRITE_EMPTY disposition caused failures after the first pipeline created the table.
Changes:
- Added explicit
WRITE_APPENDwrite disposition to the BigQuery write operation in TriggerExample
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| BigQueryIO.writeTableRows() | ||
| .to(tableRef) | ||
| .withSchema(getSchema()) | ||
| .withWriteDisposition(BigQueryIO.Write.WriteDisposition.WRITE_APPEND)); |
There was a problem hiding this comment.
The indentation for the BigQueryIO builder chain is inconsistent with other examples in the codebase. Most other examples (like AutoComplete.java:513-520, CombinePerKeyExamples.java:197-201, WriteToBigQuery.java:129-134) use 4-space indentation for chained methods, but this code uses a larger indentation (10 spaces). Consider adjusting the indentation to match the established pattern in the codebase, aligning the chained methods at 4 spaces relative to the method call context.
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @chamikaramj |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
|
|
Reminder, please take a look at this pr: @Abacn |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
|
kennknowles
left a comment
There was a problem hiding this comment.
Thanks for contributing! I just commented on the bug - actually I think the problem here is the test set up, not the examples. They should be able to write to separate tables by generating separate table names in the test set up. Changing them to "append" will make the different tests write to the same place in a way that we probably don't want.
|
Reminder, please take a look at this pr: @kennknowles |
|
waiting on author |
Fixes #18767
The TriggerExample runs multiple pipelines that write to the same BigQuery table.
The default WRITE_EMPTY disposition causes the example to fail on Dataflow after
the first pipeline creates the table.
This change explicitly sets WRITE_APPEND so all trigger pipelines can write
successfully to the same table.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit:
https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.