GH-48642: [Ruby] Add support for reading decimal128 array #48643
+208
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Ruby
awaiting committer review
kou
commented
Dec 25, 2025
Comment on lines
313
to
314
| # TODO: How to represent in Ruby? | ||
| @values_buffer.get_string(offset, byte_width) |
Member
Author
There was a problem hiding this comment.
I'll make this PR ready when I solve this TODO.
Member
Author
There was a problem hiding this comment.
Resolved. I used BigDecimal.
github-actions
bot
added
awaiting changes
kou
force-pushed
the
ruby-decimal128-array
branch
from
97d18cb to
60cbada
Compare
github-actions
bot
added
awaiting change review
github-actions
bot
added
awaiting changes
Member
Author
|
+1 |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f658199. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It's a 128 bits variant of decimal array.
What changes are included in this PR?
ArrowFormat::Decimal128TypeArrowFormat::Decimal128ArrayAre these changes tested?
Yes.
Are there any user-facing changes?
Yes.