@@ -415,9 +415,7 @@ impl RowSelection {
415415 Self :: Selectors ( selection) => {
416416 Self :: Selectors ( selection. expand_to_batch_boundaries ( batch_size, total_rows) )
417417 }
418- Self :: Mask ( mask) => {
419- Self :: Mask ( mask. expand_to_batch_boundaries ( batch_size, total_rows) )
420- }
418+ Self :: Mask ( mask) => Self :: Mask ( mask. expand_to_batch_boundaries ( batch_size, total_rows) ) ,
421419 }
422420 }
423421}
@@ -1257,8 +1255,8 @@ fn page_location_range(page: &PageLocation) -> Range<u64> {
12571255#[ cfg( test) ]
12581256mod tests {
12591257 use super :: * ;
1260- use rand:: { Rng , rng} ;
12611258 use crate :: record:: Row ;
1259+ use rand:: { Rng , rng} ;
12621260
12631261 #[ test]
12641262 fn test_from_filters ( ) {
@@ -1738,7 +1736,6 @@ mod tests {
17381736 }
17391737 }
17401738
1741-
17421739 #[ test]
17431740 fn test_iter ( ) {
17441741 // use the iter() API to show it does what is expected and
@@ -2145,64 +2142,68 @@ mod tests {
21452142
21462143 #[ test]
21472144 fn test_expand_to_batch_boundaries ( ) {
2148- test_selection ( || {
2149- // selection goes up to row 28, total 30 rows
2150- RowSelection :: from ( vec ! [
2151- // select 1 row in range 0..8
2152- RowSelector :: skip( 5 ) ,
2153- RowSelector :: select( 1 ) ,
2154- RowSelector :: skip( 2 ) ,
2155- // select no rows in range 8..16
2156- RowSelector :: skip( 8 ) ,
2157- // select 7 rows in range 16..24
2158- RowSelector :: skip( 1 ) ,
2159- RowSelector :: select( 7 ) ,
2160- // select 1 rows in range 24..30
2161- RowSelector :: skip( 4 ) ,
2162- RowSelector :: select( 1 ) ,
2163- RowSelector :: skip( 1 )
2164- ] )
2165- } , |selection| {
2166- let expanded = selection. expand_to_batch_boundaries ( 8 , 30 ) ;
2167- let expected = vec ! [
2168- RowSelector :: select( 8 ) ,
2169- RowSelector :: skip( 8 ) ,
2170- RowSelector :: select( 14 ) ,
2171- ] ;
2172-
2173- assert_eq ! ( into_selectors( & expanded) , expected) ;
2174- } ) ;
2145+ test_selection (
2146+ || {
2147+ // selection goes up to row 28, total 30 rows
2148+ RowSelection :: from ( vec ! [
2149+ // select 1 row in range 0..8
2150+ RowSelector :: skip( 5 ) ,
2151+ RowSelector :: select( 1 ) ,
2152+ RowSelector :: skip( 2 ) ,
2153+ // select no rows in range 8..16
2154+ RowSelector :: skip( 8 ) ,
2155+ // select 7 rows in range 16..24
2156+ RowSelector :: skip( 1 ) ,
2157+ RowSelector :: select( 7 ) ,
2158+ // select 1 rows in range 24..30
2159+ RowSelector :: skip( 4 ) ,
2160+ RowSelector :: select( 1 ) ,
2161+ RowSelector :: skip( 1 ) ,
2162+ ] )
2163+ } ,
2164+ |selection| {
2165+ let expanded = selection. expand_to_batch_boundaries ( 8 , 30 ) ;
2166+ let expected = vec ! [
2167+ RowSelector :: select( 8 ) ,
2168+ RowSelector :: skip( 8 ) ,
2169+ RowSelector :: select( 14 ) ,
2170+ ] ;
2171+
2172+ assert_eq ! ( into_selectors( & expanded) , expected) ;
2173+ } ,
2174+ ) ;
21752175
21762176 // test when there is no selected rows at the end
2177- test_selection ( || {
2178- RowSelection :: from ( vec ! [
2179- // select now rows in range 0..8
2180- RowSelector :: skip( 8 ) ,
2181- // select 6 rows in range 8..16
2182- RowSelector :: skip( 1 ) ,
2183- RowSelector :: select( 6 ) ,
2184- RowSelector :: skip( 1 ) ,
2185- // select a row in range 16..24
2186- RowSelector :: skip( 4 ) ,
2187- RowSelector :: select( 2 ) ,
2188- RowSelector :: skip( 2 ) ,
2189- // no rows in range 24..30
2190- RowSelector :: skip( 6 )
2191- ] )
2192- } , |selection| {
2193- let expanded = selection. expand_to_batch_boundaries ( 8 , 30 ) ;
2194- let expected = vec ! [
2195- RowSelector :: skip( 8 ) ,
2196- RowSelector :: select( 16 ) ,
2197- RowSelector :: skip( 6 ) ,
2198- ] ;
2199-
2200- assert_eq ! ( into_selectors( & expanded) , expected) ;
2201- } )
2177+ test_selection (
2178+ || {
2179+ RowSelection :: from ( vec ! [
2180+ // select now rows in range 0..8
2181+ RowSelector :: skip( 8 ) ,
2182+ // select 6 rows in range 8..16
2183+ RowSelector :: skip( 1 ) ,
2184+ RowSelector :: select( 6 ) ,
2185+ RowSelector :: skip( 1 ) ,
2186+ // select a row in range 16..24
2187+ RowSelector :: skip( 4 ) ,
2188+ RowSelector :: select( 2 ) ,
2189+ RowSelector :: skip( 2 ) ,
2190+ // no rows in range 24..30
2191+ RowSelector :: skip( 6 ) ,
2192+ ] )
2193+ } ,
2194+ |selection| {
2195+ let expanded = selection. expand_to_batch_boundaries ( 8 , 30 ) ;
2196+ let expected = vec ! [
2197+ RowSelector :: skip( 8 ) ,
2198+ RowSelector :: select( 16 ) ,
2199+ RowSelector :: skip( 6 ) ,
2200+ ] ;
22022201
2202+ assert_eq ! ( into_selectors( & expanded) , expected) ;
2203+ } ,
2204+ )
22032205 }
22042206
2205-
22062207 /// Runs `verify_fn(s1)` with both Mask and Selector backed cursors
22072208 ///
22082209 /// This is used to ensuring both cursor types behave identically
@@ -2318,6 +2319,4 @@ mod tests {
23182319 fn into_selectors ( selection : & RowSelection ) -> Vec < RowSelector > {
23192320 selection. clone ( ) . into ( )
23202321 }
2321-
2322-
23232322}
0 commit comments