Skip to content

Commit 7f307c0

Browse files
authored
fix: Stop using https://dist.apache.org/repos/dist/dev/arrow/KEYS for verification (#9604)
# Which issue does this PR close? - Closes #9603 # Rationale for this change The release and dev KEYS files could get out of synch. We should use the release/ version: - Users use the release/ version not dev/ version when they verify our artifacts' signature - https://dist.apache.org/ may reject our request when we request many times by CI # What changes are included in this PR? Use `https://www.apache.org/dyn/closer.lua?action=download&filename=arrow/KEYS` to download the KEYS file and the expected `https://dist.apache.org/repos/dist/dev/arrow` for the RC artifacts. # Are these changes tested? Yes, I've verified 58.1.0 1 both previous to the change and after the change. # Are there any user-facing changes? No
1 parent 1f1c3a4 commit 7f307c0

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

dev/release/verify-release-candidate.sh

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,23 +33,27 @@ set -o pipefail
3333

3434
SOURCE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]:-$0}")" && pwd)"
3535
ARROW_DIR="$(dirname $(dirname ${SOURCE_DIR}))"
36-
ARROW_DIST_URL='https://dist.apache.org/repos/dist/dev/arrow'
36+
ARROW_RC_URL="https://dist.apache.org/repos/dist/dev/arrow"
37+
ARROW_KEYS_URL="https://www.apache.org/dyn/closer.lua?action=download&filename=arrow/KEYS"
3738

38-
download_dist_file() {
39+
download_file() {
3940
curl \
4041
--silent \
4142
--show-error \
4243
--fail \
4344
--location \
44-
--remote-name $ARROW_DIST_URL/$1
45+
--output "$2" \
46+
"$1"
4547
}
4648

4749
download_rc_file() {
48-
download_dist_file apache-arrow-rs-${VERSION}-rc${RC_NUMBER}/$1
50+
download_file \
51+
"${ARROW_RC_URL}/apache-arrow-rs-${VERSION}-rc${RC_NUMBER}/$1" \
52+
"$1"
4953
}
5054

5155
import_gpg_keys() {
52-
download_dist_file KEYS
56+
download_file "${ARROW_KEYS_URL}" KEYS
5357
gpg --import KEYS
5458
}
5559

0 commit comments

Comments
 (0)