Avoid redundant check

Author: alamb

arrow-array/src/builder/primitive_builder.rs

@@ -183,14 +183,10 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
     ///
     /// # Panics
     ///
-    /// This method panics if `data_type` is not [PrimitiveArray::is_compatible]
+    /// This method will not panic, but [`Self::build`], [`Self::finish`] will panics if `data_type` is
+    /// not [PrimitiveArray::is_compatible] with the builder's primitive type
+    /// `T`.
     pub fn with_data_type(self, data_type: DataType) -> Self {
-        assert!(
-            PrimitiveArray::<T>::is_compatible(&data_type),
-            "incompatible data type for builder, expected {} got {}",
-            T::DATA_TYPE,
-            data_type
-        );
         Self {
             data_type: Some(data_type),
             ..self
@@ -662,9 +658,23 @@ mod tests {
     }
 
     #[test]
-    #[should_panic(expected = "incompatible data type for builder, expected Int32 got Int64")]
-    fn test_invalid_with_data_type() {
-        Int32Builder::new().with_data_type(DataType::Int64);
+    #[should_panic(expected = "PrimitiveArray expected data type Int32 got Int64")]
+    fn test_invalid_with_data_type_finish() {
+        Int32Builder::new().with_data_type(DataType::Int64).finish();
+    }
+
+    #[test]
+    #[should_panic(expected = "PrimitiveArray expected data type Int32 got Int64")]
+    fn test_invalid_with_data_type_finish_cloned() {
+        Int32Builder::new()
+            .with_data_type(DataType::Int64)
+            .finish_cloned();
+    }
+
+    #[test]
+    #[should_panic(expected = "PrimitiveArray expected data type Int32 got Int64")]
+    fn test_invalid_with_data_type_build() {
+        Int32Builder::new().with_data_type(DataType::Int64).build();
     }
 
     #[test]