Address PR feedback.

Author: mbutrovich

arrow-buffer/src/buffer/null.rs

@@ -87,9 +87,11 @@ impl NullBuffer {
     /// Computes the union of the nulls in multiple optional [`NullBuffer`]s
     ///
     /// See [`union`](Self::union)
-    pub fn union_many(nulls: &[Option<&NullBuffer>]) -> Option<NullBuffer> {
+    pub fn union_many<'a>(
+        nulls: impl IntoIterator<Item = Option<&'a NullBuffer>>,
+    ) -> Option<NullBuffer> {
         // Unwrap to BooleanBuffer because BitAndAssign is not implemented for NullBuffer
-        let mut buffers = nulls.iter().filter_map(|nb| nb.map(NullBuffer::inner));
+        let mut buffers = nulls.into_iter().filter_map(|nb| nb.map(NullBuffer::inner));
         let first = buffers.next()?;
         let mut result = first.clone();
         for buf in buffers {
@@ -353,22 +355,22 @@ mod tests {
 
     #[test]
     fn test_union_many_all_none() {
-        let result = NullBuffer::union_many(&[None, None, None]);
+        let result = NullBuffer::union_many([None, None, None]);
         assert!(result.is_none());
     }
 
     #[test]
     fn test_union_many_single_some() {
         let a = NullBuffer::from(&[true, false, true, true]);
-        let result = NullBuffer::union_many(&[Some(&a)]);
+        let result = NullBuffer::union_many([Some(&a)]);
         assert_eq!(result, Some(a));
     }
 
     #[test]
     fn test_union_many_two_inputs() {
         let a = NullBuffer::from(&[true, false, true, true]);
         let b = NullBuffer::from(&[true, true, false, true]);
-        let result = NullBuffer::union_many(&[Some(&a), Some(&b)]);
+        let result = NullBuffer::union_many([Some(&a), Some(&b)]);
         let expected = NullBuffer::union(Some(&a), Some(&b));
         assert_eq!(result, expected);
     }
@@ -378,7 +380,7 @@ mod tests {
         let a = NullBuffer::from(&[true, false, true, true]);
         let b = NullBuffer::from(&[true, true, false, true]);
         let c = NullBuffer::from(&[false, true, true, true]);
-        let result = NullBuffer::union_many(&[Some(&a), Some(&b), Some(&c)]);
+        let result = NullBuffer::union_many([Some(&a), Some(&b), Some(&c)]);
         let expected = NullBuffer::from(&[false, false, false, true]);
         assert_eq!(result, Some(expected));
     }
@@ -387,14 +389,14 @@ mod tests {
     fn test_union_many_mixed_none() {
         let a = NullBuffer::from(&[true, false, true, true]);
         let b = NullBuffer::from(&[false, true, true, true]);
-        let result = NullBuffer::union_many(&[Some(&a), None, Some(&b)]);
+        let result = NullBuffer::union_many([Some(&a), None, Some(&b)]);
         let expected = NullBuffer::union(Some(&a), Some(&b));
         assert_eq!(result, expected);
     }
 
     #[test]
     fn test_union_many_empty_slice() {
-        let result = NullBuffer::union_many(&[]);
+        let result = NullBuffer::union_many([] as [Option<&NullBuffer>; 0]);
         assert!(result.is_none());
     }
 }