Some surveys in survey_list have incorrect contents in 'method' field

[LizziOh]

For example survey

912351271 and 912351272 - neither have method 2 observations however have 1,2 in the methods field in the survey_list endpoint.

They display correctly in the UI

@bpasquer @atcooper1

[LizziOh]

I believe its an issue that when 'Survey not done' is TRUE then that method gets recorded as done.

[bpasquer]

Hi Lizzi, you are almost right:
As you said, M2 is correctly recorded as 'survey_not_done' in the survey_method table:

survey_method_id	survey_id	method_id	block_num	survey_not_done
12485	912351271	2	1	true
12486	912351271	1	1	false
12487	912351271	1	2	false
12488	912351271	2	2	true
56987	912351272	2	2	true
56988	912351272	1	1	false
56989	912351272	2	1	true
56990	912351272	1	2	false

This code snippet of the ep_survey_list endpoint provides the list of methods done in a survey:

SELECT string_agg(DISTINCT sm1.method_id::character varying(3)::text, ', '::text
                          ORDER BY (sm1.method_id::character varying(3)::text)) AS string_agg
        FROM nrmn.survey_method sm1
        WHERE sm1.survey_id = sur.survey_id
        GROUP BY sm1.survey_id

As you can see, it simply aggregates all the methods listed in the survey_method table above without excluding records where survey_not_done is True. Adding a condition as below will produce the correct output:

SELECT string_agg(DISTINCT sm1.method_id::character varying(3)::text, ', '::text
                         ORDER BY (sm1.method_id::character varying(3)::text)) AS string_agg
        FROM nrmn.survey_method sm1
        WHERE sm1.survey_id = sur.survey_id AND sm1.survey_not_done=false
        GROUP BY sm1.survey_id

[LizziOh]

Thanks for looking into this Bene,
Yes adding that condition would be good please!

[utas-raymondng]

Here are some data for the autotest for the 2 PRs. Let me know if it suits you.

#1368

SELECT methods FROM nrmn.ep_survey_list WHERE survey_id IN (912351270,912351271,912351272)

Current results:
1,2
1,2
1,2
Expected result:
1,2
1
1

Note that it appears that this script has already been run in Edge ( I must have ask havier to run it more than 3 month ago cause I can't find the message in slack)

---

#1384

SELECT reporting_name,method,block,size_class,total FROM ep_m2_inverts
WHERE survey_id =812331754
AND reporting_name IN ('Centrostephanus rodgersii','Plagusia chabrus','Heliocidaris erythrogramma')

Current results:
Plagusia chabrus,2,1,7.5,1
Centrostephanus rodgersii,2,1,10,1
Centrostephanus rodgersii,2,1,10,8
Centrostephanus rodgersii,2,1,10,4
Heliocidaris erythrogramma,2,1,7.5,1
Heliocidaris erythrogramma,2,1,10,5

[utas-raymondng]

add test to cover upcoming change to 1368 -> #1393 and #1394

add test to cover #1384 -> #1395