From 07e5f3fe8630124ef529e665c4e08b8c41ac4dfa Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sun, 16 Oct 2022 03:58:17 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- conda2wheel/__init__.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/conda2wheel/__init__.py b/conda2wheel/__init__.py index 5beb7ef..48a0782 100644 --- a/conda2wheel/__init__.py +++ b/conda2wheel/__init__.py @@ -14,7 +14,26 @@ def extract(condafile, workdir): with tarfile.open(condafile) as f: - f.extractall(workdir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(f, workdir) def find_eggifo(workdir):