SOLIDUI: use consistent light theme icon

[jesscmoore]

Describe the Bug

Currently the app bar light theme icon is different to the login window light theme icon. These should be consistent. The light theme icon in the login window is more obviously a change to light theme icon. The light theme icon in the app bar is not obviously recognisable as indicating light theme

Expected Behaviour

Consistent, recognisable, theme buttons

Screenshots

Eg in notepod

App bar

And login window:

Context

Where has the issue been observed:

• Android
• Chrome
• iOS
• Linux
• macOS
• Web
• Windows

[Add any other context about the problem here.]

App Version: notepod 0.3.4+9, solidui: 0.0.23
Flutter Version: 3.38.5

Closing Criteria

Checklist for closing the issue:

• No errors from make prep
• All tests pass make qtest
• [Issue specific requirements.]

[gjwgit]

Agreed. I was about to raise this issue too. I prefer this to be the icon to use in both places:

[tonypioneer]

Hi @jesscmoore, I think the icon in the screenshot with a letter A is the icon of system mode. In this mode, the theme mode will be consistent with the system. Since in the preferences settings, the Adaptive Toogle is on by default, so the theme mode which is the same as the current system mode will be hidden, and you can only see the icon of dark mode and system mode in the appbar.

I think I can adjust code to replace the solid sun icon for the light mode with the outlined sun icon, to make it consistent with the login page.

[gjwgit]

A couple of points here, I think

We need to get rid of having both SETTINGS and PREFERENCES - there should be just one?

I think this needs to be simplified. If the system mode is currently LIGHT then there should be just the toggle between DARK and then LIGHT. If the system mode is currently DARK then the toggle should show LIGHT and then DARK. It is still confusing at present I think - noting our discussion last year.

[tonypioneer]

A couple of points here, I think

We need to get rid of having both SETTINGS and PREFERENCES - there should be just one?

I think this needs to be simplified. If the system mode is currently LIGHT then there should be just the toggle between DARK and then LIGHT. If the system mode is currently DARK then the toggle should show LIGHT and then DARK. It is still confusing at present I think - noting our discussion last year.

• I removed the Settings Page from the app bar. The Settings Page was originally a sample page created to demonstrate the navigateToSubpage() function. I replaced it with a Sample Page to avoid confusion caused by the name.

• The current Sample Page button is a button that is laid out only in the app bar and does not appear in the navigation rail. It forms a group of sample buttons together with the Files button on its left. The Files button appears both in the app bar and in the navigation rail. Users can use navigateToSubpage() to navigate to either the Sample Page or the Files page. The difference is that when navigating to the Files page, the Files button in the left navigation rail will be highlighted, whereas when navigating to the Sample Page, no button in the navigation rail will be highlighted, since the Sample Page does not have a corresponding navigation rail item.

I also updated the system theme mode icons to make them easier to understand. When the Adaptive Toggle in Preferences is enabled, pressing the theme mode button in the app bar will only switch between system mode and the opposite mode.

• When the system mode is light mode, it will only toggle between system mode and dark mode. The system mode icon will be shown as a sun (indicating the next mode), with an “A” displayed in the bottom-right corner to indicate that this is system mode.

system mode -> dark mode -> system mode -> dark mode -> ...

• When the system mode is dark mode, it will only toggle between system mode and light mode. Similarly, the system mode icon will be shown as a moon with an “A”.

system mode -> light mode -> system mode -> light mode -> ...

• When the user manually changes the system mode from light mode to dark mode in the operating system settings, the app bar icon will automatically switch from sun + A to moon + A.

system mode (including the icon) can automatically switch according to the system settings

When the Adaptive Toggle is turned off in Preferences, all three modes—system mode, light mode, and dark mode—will appear in sequence. Duplicate modes will not be intelligently hidden.

system mode -> light mode -> dark mode -> system mode -> light mode -> dark mode -> ...