Lint issues

[gjwgit]

Currently getting a lot of lint issues - can they be reviewed please. Thanks

$ make prep

Futter ANALYZE
flutter analyze
Resolving dependencies... 
Downloading packages... 
  characters 1.4.0 (1.4.1 available)
  crypto_keys 0.3.0+1 (0.3.0+2 available)
  fast_rsa 3.8.4 (3.8.5 available)
  http 1.4.0 (1.5.0 available)
  material_color_utilities 0.11.1 (0.13.0 available)
  meta 1.16.0 (1.17.0 available)
  pointycastle 3.9.1 (4.0.0 available)
  test_api 0.7.6 (0.7.7 available)
  url_launcher 6.3.1 (6.3.2 available)
  url_launcher_android 6.3.16 (6.3.22 available)
  url_launcher_ios 6.3.3 (6.3.4 available)
  url_launcher_macos 3.2.2 (3.2.3 available)
Got dependencies!
12 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.
Resolving dependencies in `./example`... 
Because every version of solid_auth from path depends on pointycastle ^3.9.1 and dart_jsonwebtoken 3.2.0 depends on pointycastle ^4.0.0, solid_auth from path is incompatible with
  dart_jsonwebtoken 3.2.0.
And because no versions of dart_jsonwebtoken match >3.2.0 <4.0.0, solid_auth from path is incompatible with dart_jsonwebtoken ^3.2.0.
So, because solid_auth_example depends on both dart_jsonwebtoken ^3.2.0 and solid_auth from path, version solving failed.


You can try the following suggestion to make the pubspec resolve:
* Consider downgrading your constraint on dart_jsonwebtoken: flutter pub add dart_jsonwebtoken:^3.1.1
Failed to update packages.
make: [support/flutter.mk:188: analyze] Error 1 (ignored)

Dart Code Metrics: UNUSED CODE
metrics check-unused-code --disable-sunset-warning lib
✔ Analysis is completed. Preparing the results: 2.3s

lib/solid_auth_client.dart:
    ⚠ unused function authenticate
      at /home/gjw/git/github/anusii/solid_auth/lib/solid_auth_client.dart:103:1
    ⚠ unused function logout
      at /home/gjw/git/github/anusii/solid_auth/lib/solid_auth_client.dart:261:1

lib/solid_auth_issuer.dart:
    ⚠ unused function getIssuer
      at /home/gjw/git/github/anusii/solid_auth/lib/solid_auth_issuer.dart:3:1

lib/src/jwt/src/ed25519/const.dart:
    ⚠ unused top level variable A
      at /home/gjw/git/github/anusii/solid_auth/lib/src/jwt/src/ed25519/const.dart:46:1

lib/src/jwt/src/ed25519/export.dart:
    ⚠ unused function public
      at /home/gjw/git/github/anusii/solid_auth/lib/src/jwt/src/ed25519/export.dart:57:1
    ⚠ unused function seed
      at /home/gjw/git/github/anusii/solid_auth/lib/src/jwt/src/ed25519/export.dart:62:1
    ⚠ unused function generateKey
      at /home/gjw/git/github/anusii/solid_auth/lib/src/jwt/src/ed25519/export.dart:70:1

lib/src/openid/openid_client_io.dart:
    ⚠ unused extension FlowX
      at /home/gjw/git/github/anusii/solid_auth/lib/src/openid/openid_client_io.dart:123:1

✖ total unused code (classes, functions, variables, extensions, enums, mixins and type aliases) - 8
make: [support/flutter.mk:489: unused_code] Error 1 (ignored)

Files without a LICENSE:

        lib/solid_auth_client.dart
        lib/solid_auth_issuer.dart
        lib/solid_auth.dart
        lib/src/jwt/dart_jsonwebtoken.dart
        lib/src/jwt/src/errors.dart
        lib/src/jwt/src/keys.dart
        lib/src/jwt/src/utils.dart
        lib/src/jwt/src/algorithms.dart
        lib/src/jwt/src/ed25519/ed25519.dart
        lib/src/jwt/src/ed25519/const.dart
        lib/src/jwt/src/ed25519/export.dart
        lib/src/jwt/src/ed25519/util.dart
        lib/src/jwt/src/jwt.dart
        lib/src/jwt/src/parser.dart
        lib/src/auth_manager/auth_manager_stub.dart
        lib/src/auth_manager/auth_manager_abstract.dart
        lib/src/auth_manager/web_auth_manager.dart
        lib/src/openid/openid_client_browser.dart
        lib/src/openid/openid_client_io.dart
        lib/src/openid/src/model/token.dart
        lib/src/openid/src/model/claims.dart
        lib/src/openid/src/model/metadata.dart
        lib/src/openid/src/model/token_response.dart
        lib/src/openid/src/http_util.dart
        lib/src/openid/src/model.dart
        lib/src/openid/src/openid.dart
        lib/src/openid/openid_client.dart
        lib/platform_info.dart

❌ Error: Files with no license found.
make: [support/flutter.mk:283: license] Error 1 (ignored)

------------------------------------------------------------------------
Markdown: MARKDOWN FORMAT CHECK.
markdownlint --disable MD036 -- *.md lib assets installers
CHANGELOG.md:43:81 MD013/line-length Line length [Expected: 80; Actual: 102]
README.md:47:8 MD059/descriptive-link-text Link text should be descriptive [Context: "[here]"]
README.md:130:81 MD013/line-length Line length [Expected: 80; Actual: 142]
README.md:135:81 MD013/line-length Line length [Expected: 80; Actual: 88]
README.md:137:81 MD013/line-length Line length [Expected: 80; Actual: 111]
make: [support/flutter.mk:264: markdown] Error 1 (ignored)

------------------------------------------------------------------------
Dart: REVIEW DEPENDENCIES.
dependency_validator

Validating dependencies for solid_auth...
These packages are used outside lib/ but are not dev_dependencies:
  * flutter_lints
  * flutter_test
  * solid_auth_example
make: [support/flutter.mk:197: depend] Error 1 (ignored)