diff --git a/crates/forge_app/src/git_app.rs b/crates/forge_app/src/git_app.rs index c798aa463f..227622c11c 100644 --- a/crates/forge_app/src/git_app.rs +++ b/crates/forge_app/src/git_app.rs @@ -323,7 +323,7 @@ where Ok(provider) => (provider, commit_model), Err(err) => { tracing::warn!( - error = %err, + error = ?err, "Failed to refresh credentials for configured commit provider. Falling back to the active provider." ); self.resolve_agent_provider_and_model( @@ -336,7 +336,7 @@ where } Err(err) => { tracing::warn!( - error = %err, + error = ?err, "Configured commit provider unavailable. Falling back to the active provider." ); self.resolve_agent_provider_and_model(&agent_provider_resolver, agent_id) diff --git a/crates/forge_app/src/hooks/title_generation.rs b/crates/forge_app/src/hooks/title_generation.rs index 60cbe4db60..a16543f561 100644 --- a/crates/forge_app/src/hooks/title_generation.rs +++ b/crates/forge_app/src/hooks/title_generation.rs @@ -131,7 +131,7 @@ impl EventHandle> for TitleGenerationHand self.title_tasks.remove(&conversation.id); } Err(e) => { - debug!(error = %e, "Title generation task failed"); + debug!(error = ?e, "Title generation task failed"); // Remove so a future StartPayload can retry. self.title_tasks.remove(&conversation.id); } diff --git a/crates/forge_repo/src/app_config.rs b/crates/forge_repo/src/app_config.rs index 65e9367a9a..158a9f9707 100644 --- a/crates/forge_repo/src/app_config.rs +++ b/crates/forge_repo/src/app_config.rs @@ -40,7 +40,7 @@ impl AppConfigRepositor Err(e) => { tracing::error!( path = %path.display(), - error = %e, + error = ?e, "Failed to read config file. Using default config." ); return AppConfig::default(); @@ -59,7 +59,7 @@ impl AppConfigRepositor .inspect_err(|e| { tracing::error!( path = %path.display(), - error = %e, + error = ?e, "Failed to repair config file. Using default config." ); }) diff --git a/crates/forge_repo/src/database/pool.rs b/crates/forge_repo/src/database/pool.rs index 2ed368e106..47369bb398 100644 --- a/crates/forge_repo/src/database/pool.rs +++ b/crates/forge_repo/src/database/pool.rs @@ -66,7 +66,7 @@ impl DatabasePool { pub fn get_connection(&self) -> Result { self.pool.get().map_err(|e| { - warn!(error = %e, "Failed to get connection from pool"); + warn!(error = ?e, "Failed to get connection from pool"); anyhow::anyhow!("Failed to get connection from pool: {e}") }) } @@ -123,7 +123,7 @@ impl TryFrom for DatabasePool { } let pool = builder.build(manager).map_err(|e| { - warn!(error = %e, "Failed to create connection pool"); + warn!(error = ?e, "Failed to create connection pool"); anyhow::anyhow!("Failed to create connection pool: {e}") })?; @@ -133,7 +133,7 @@ impl TryFrom for DatabasePool { .map_err(|e| anyhow::anyhow!("Failed to get connection for migrations: {e}"))?; connection.run_pending_migrations(MIGRATIONS).map_err(|e| { - warn!(error = %e, "Failed to run database migrations"); + warn!(error = ?e, "Failed to run database migrations"); anyhow::anyhow!("Failed to run database migrations: {e}") })?; diff --git a/crates/forge_repo/src/provider/chat.rs b/crates/forge_repo/src/provider/chat.rs index aa7021cc45..2017cedcb9 100644 --- a/crates/forge_repo/src/provider/chat.rs +++ b/crates/forge_repo/src/provider/chat.rs @@ -97,11 +97,11 @@ impl ChatRepository for ForgeChatReposit match router.models(provider).await { Ok(models) => { if let Err(err) = cache.cache_set(&key, &models).await { - tracing::warn!(error = %err, "background refresh: failed to cache model list"); + tracing::warn!(error = ?err, "background refresh: failed to cache model list"); } } Err(err) => { - tracing::warn!(error = %err, "background refresh: failed to fetch models"); + tracing::warn!(error = ?err, "background refresh: failed to fetch models"); } } }); @@ -113,7 +113,7 @@ impl ChatRepository for ForgeChatReposit let models = self.router.models(provider).await?; if let Err(err) = self.model_cache.cache_set(&cache_key, &models).await { - tracing::warn!(error = %err, "failed to cache model list"); + tracing::warn!(error = ?err, "failed to cache model list"); } Ok(models)