The mesh position should be set *before* calling addMesh, not inside it

[DavidBruant]

The mesh should know its own position. Move this to client.js
https://github.com/DavidBruant/bordeaux3d-core/commit/fe2d7a9923d33ae40492e140d75deaa3901f9fb4#diff-44b390af6d21196c55fb50f726184ffcR100

[bleucitron]

I agree, but in the actual state of what the AddMesh button does (positioning the cube in front of the camera), this would need the camera to be exported by index.js. I'm not sure this is a good thing.
Also, in the future, we need to think about how the user will be able to position its own meshes.

[DavidBruant]

this would need the camera to be exported by index.js

It is ;-)
And it's been exported for other reasons

city-core/core-client/client.js

Lines 35 to 51 in 42347d0

	// initial position
	bordeaux3D.camera.position.x = 24341.22;
	bordeaux3D.camera.position.y = 10967.65;
	bordeaux3D.camera.position.z = skyViewAltitude;
	function toggleControls(){
	console.log('toggleControls', nextControls);
	if(nextControls === "sky"){
	bordeaux3D.changeControls(SkyViewControls, { z: skyViewAltitude });
	//window.addEventListener('meshClicked', onMeshClicked);
	controlsButton.textContent = buttonMessage[nextControls];
	nextControls = "first person";
	}
	else{
	skyViewAltitude = bordeaux3D.camera.position.z;

[DavidBruant]

we need to think about how the user will be able to position its own meshes.

True. For now, we can expect the position is encoded in the 3ds.

[DavidBruant]

Sorry, I meant the mesh, not the 3ds.

[bleucitron]

Okay, i wasn't working with the latest code you wrote, so i didn't have the camera exported. Review and merge #88 if you're ok with it, and i'll pull latest version of core-separation to fix this.

[DavidBruant]

It's a small change so push it as part of #88 (but in its own commit which references this issue).
I'm working on something else today, so I'll merge this week-end or on Monday.

As soon as #88 is merged, we should move the master branch to the top of core-separation, because the biggest part of the work is done and the API has proven to work with core-client.