fix: display recent/favourited models both in recents/favourites subgrouping and under their provider (resolves #3874) #5538
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er lists Fixes anomalyco#3874 by removing filter that excluded recent/favorite models from their provider sections. Now models appear in: - Recent section (if recently used, not a favorite) - Favorites section (if favorited) - Their provider section (e.g., Zen, Anthropic, etc.) Favorited models in provider lists still show (Favorite) indicator.
Added category field to value objects in dialog-model.tsx to make each option unique when same model appears in multiple sections (Recent, Favorites, Provider lists). Only one item highlights now when navigating with keyboard. Changes: - Added category to favoriteOptions value object - Added category to recentOptions value object - Added category to provider list options value object - Updated toggleFavorite keybind to handle new structure
ariane-emory
changed the title
ariane-emory
changed the title
ariane-emory
changed the title
ariane-emory
force-pushed
the
fix/display-recents-consistency
branch
from
8fbe399 to
aa0cfa4
Compare
ariane-emory
force-pushed
the
fix/display-recents-consistency
branch
from
6637c5d to
c6236a8
Compare
… underline prop" This reverts commit eb91f95.
…mory/opencode into fix/display-recents-consistency
Contributor
Author
|
Clobbered by recent updates, would require nontrivial reworking to be made to work properly now. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects a behaviour that is currently surprising some users, where recent/favourited models are displayed in only the recents/favourites subsection of the
/modelslist and not under their original provider. After this PR, recent/favourited models will show up in the list both under the recents/favourites grouping and under their actual provider.Resolves #3874.