-
Notifications
You must be signed in to change notification settings - Fork 4
CSS Improvement - Convert Pixel Units to rem #2
Copy link
Copy link
Open
Labels
beginner friendlygood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
Description
The project currently mixes px and rem units. As noted in the todo file, we should standardize to use rem units for better accessibility and responsive design. This helps users who have adjusted their browser's font size.
Acceptance Criteria
- Convert all
pxunits toremunits in both CSS files - Maintain visual consistency (elements should look the same)
- Keep the existing
html { font-size: 10px; }for easy rem calculations - Test on different screen sizes to ensure responsiveness
Technical Details
With html { font-size: 10px; }, the conversion is straightforward:
10px=1rem16px=1.6rem32px=3.2rem
Files to Modify
-
styles.css- Convert px to rem values -
luckyNumberStyles.css- Convert px to rem values
Resources/References
Estimated Difficulty: Beginner Friendly ⭐
Additional Notes
This is perfect for beginners to learn about CSS units and accessibility. The math is simple with the 10px base font size!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
beginner friendlygood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed