Double left click in deepd3-inference not working

[dominicadt]

Hello,

I am having a similar issue that was referenced to in issue #5. I am testing the deepd3-inference GUI using your benchmark dataset and models.

I can load the data and segment the dendrites and spines fine, but when I double click to open the supplementary GUI for editing the annotations I get an error about unexpected floats:

    Traceback (most recent call last):
      File "C:\Code\DeepD3\DeepD3_py310\lib\site-packages\deepd3\inference\gui.py", line 829, in testROIbuilding
        self.testROIwindow = testROI(self.S.stack[z-3:z+3, y-h//2:y+h//2, x-w//2:x+w//2],
      File "C:\Code\DeepD3\DeepD3_py310\lib\site-packages\deepd3\inference\gui.py", line 518, in __init__
        self.gaussianFilter.setMinimum(0.0)
      File "C:\Code\DeepD3\DeepD3_py310\lib\site-packages\deepd3\inference\gui.py", line 479, in setMinimum
        return super(DoubleSlider, self).setMinimum(value * self._multi)
    TypeError: setMinimum(self, a0: int): argument 1 has unexpected type 'float'

My current versions and environment details are

python 3.10.8
PyQt5 5.15.11
PyQt5-Qt5 5.15.2
PyQt5_sip 12.18.0
pyqtgraph 0.14.0
Windows 11 Version 24H2

I tried older version of PyQt5 (oldest I tried was 5.15.8), but I still got the same error.

I would appreciate any support or suggestions. Thanks in advance!

[anki-xyz]

Dear @dominicadt - please go to your file C:\Code\DeepD3\DeepD3_py310\lib\site-packages\deepd3\inference\gui.py to line 518 and change the line self.gaussianFilter.setMinimum(0.0) to self.gaussianFilter.setMinimum(0). In the current commit, we already fixed this. However, the PyPI version of deepd3 is maybe still unfixed (couldn't check because PyPI is teasing me the security steps). I try to ensure that PyPI is then on the latest commit.

[lschm]

Hi,

I did this fix and it did not help, I had to cast it to integer:

return super(DoubleSlider, self).setMinimum(int(value * self._multi))

I think the same problem appeared and was solved by this step in different places.

I am working with the pip install and spend quite some time debugging it this week - both to run it on GPU and to fix the batch script. Let me know if the solutions I found would be helpful @anki-xyz

[dominicadt]

the integer fix also worked for me! Had to change it in lines 479, 482, 485 and 491.

def setMinimum(self, value):
    return super(DoubleSlider, self).setMinimum(**int**(value * self._multi))

def setMaximum(self, value):
    return super(DoubleSlider, self).setMaximum(**int**(value * self._multi))

def setSingleStep(self, value):
    return super(DoubleSlider, self).setSingleStep(**int**(value * self._multi))

def singleStep(self):
    return float(super(DoubleSlider, self).singleStep()) / self._multi

def setValue(self, value):
    super(DoubleSlider, self).setValue(**int**(value * self._multi))

thanks for the suggestion @lschm