Skip to content

Cannot use PingResult::merge in Plugin #489

@marek22k

Description

@marek22k

Describe the bug
Cannot use PingResult::merge in Plugin

To Reproduce

package bandura.ipscan.plugins;

import edu.umd.cs.findbugs.annotations.CheckReturnValue;
import edu.umd.cs.findbugs.annotations.NonNull;

import java.io.IOException;

import net.azib.ipscan.core.ScanningSubject;
import net.azib.ipscan.core.net.JavaPinger;
import net.azib.ipscan.core.net.PingResult;
import net.azib.ipscan.core.net.Pinger;
import net.azib.ipscan.core.net.TCPPinger;
import net.azib.ipscan.core.net.UDPPinger;

/**
 * Pinger, which combines Java build-in pinger, UDP Pinger and TCP Pinger
 */
public class ThreeTypePinger implements Pinger {
    private JavaPinger javaPinger;
    private UDPPinger udpPinger;
    private TCPPinger tcpPinger;

    public ThreeTypePinger(JavaPinger javapinger, TCPPinger tcpPinger, UDPPinger udpPinger) {
        this.javaPinger = javaPinger;
        this.udpPinger = udpPinger;
        this.tcpPinger = tcpPinger;
    }

    @CheckReturnValue
    @NonNull
    @Override
    public PingResult ping(ScanningSubject subject, int count) throws IOException {
        // try Java Build-in first - as it could use ICMP
        // minimum three tries to prevent packet loss in unreliable networks
        int javaBuiltinInitialCount = Math.max(3, count / 3);
        PingResult javaBuiltinResult = this.javaPinger.ping(subject, javaBuiltinInitialCount);
        if (javaBuiltinResult.isAlive()) {
            return javaBuiltinResult.merge(javaPinger.ping(subject, count - javaBuiltinInitialCount));
        }

        // try UDP second - it should be more reliable than TCP, but less than ICMP
        // minimum three tries to prevent packet loss in unreliable networks
        int udpCountInitialCount = Math.max(3, count / 3);
        PingResult udpResult = udpPinger.ping(subject, udpCountInitialCount);
        if (udpResult.isAlive()) {
            return udpResult.merge(udpPinger.ping(subject, count - udpCountInitialCount));
        }

        // fallback to TCP - it may detect some hosts Java Built-in, UDP cannot
        // minimum five tries to try all ports
        int tcpPingerInitialCount = max(5, count / 3);
        return tcpPinger.ping(subject, count);
    }
}
/home/marek/eclipse-workspace/ipscan-plugins/three-type-pinger/src/bandura/ipscan/plugins/ThreeTypePinger.java:42: error: merge(PingResult) is not public in PingResult; cannot be accessed from outside package
            return javaBuiltinResult.merge(javaPinger.ping(subject, count - javaBuiltinInitialCount));
                                    ^
/home/marek/eclipse-workspace/ipscan-plugins/three-type-pinger/src/bandura/ipscan/plugins/ThreeTypePinger.java:50: error: merge(PingResult) is not public in PingResult; cannot be accessed from outside package
            return udpResult.merge(udpPinger.ping(subject, count - udpCountInitialCount));

Expected behavior
Method is public

Screenshots
If applicable, add screenshots to help explain your problem.

Versions (please copy from the About dialog or complete manually):
commit 5c667ce

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions