Skip to content

Replace UiAutomator onView with onElement #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AjeshRPai merged 1 commit into from
Jul 29, 2025
Merged

Replace UiAutomator onView with onElement #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...main/kotlin/com/android/developers/androidify/baselineprofile/BaselineProfileGenerator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ class BaselineProfileGenerator {
) {
uiAutomator {
startApp(packageName = packageName)
onView { textAsString() == "Let's Go" }.click()
onView { textAsString() == "Prompt" }.click()
onView { isEditable }.apply {
onElement { textAsString() == "Let's Go" }.click()
onElement{ textAsString() == "Prompt" }.click()
onElement{ isEditable }.apply {
Comment on lines +49 to +50
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency and adherence to Kotlin's coding conventions, it's best to add a space between the function name and the opening brace of the lambda expression.1

Style Guide References

Suggested change
onElement{ textAsString() == "Prompt" }.click()
onElement{ isEditable }.apply {
onElement { textAsString() == "Prompt" }.click()
onElement { isEditable }.apply {

Footnotes

  1. The official Kotlin style guide recommends a space between a function name and the opening brace of a lambda expression. This improves code readability. ↩

click()
text =
"wearing brown sneakers, a red t-shirt, " +
Expand Down
6 changes: 3 additions & 3 deletions benchmark/src/main/kotlin/com/android/developers/androidify/benchmark/PromptBenchmark.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ class PromptBenchmark {
) {
uiAutomator {
startApp(packageName = packageName)
onView { textAsString() == "Let's Go" }.click()
onView { textAsString() == "Prompt" }.click()
onView { isEditable }.apply {
onElement { textAsString() == "Let's Go" }.click()
onElement { textAsString() == "Prompt" }.click()
onElement { isEditable }.apply {
click()
text =
"wearing brown sneakers, a red t-shirt, " +
Expand Down