From de6a45e7a555ae4aacd94f3484330a37625b5fe8 Mon Sep 17 00:00:00 2001 From: Simon Marquis Date: Sat, 31 May 2025 14:08:24 +0100 Subject: [PATCH] Replace unnecessary init block with direct instantiation in HomeViewModel.kt --- .../androidify/home/HomeViewModel.kt | 21 +++++++------------ 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/feature/home/src/main/java/com/android/developers/androidify/home/HomeViewModel.kt b/feature/home/src/main/java/com/android/developers/androidify/home/HomeViewModel.kt index 1077dbdf..40d3ab14 100644 --- a/feature/home/src/main/java/com/android/developers/androidify/home/HomeViewModel.kt +++ b/feature/home/src/main/java/com/android/developers/androidify/home/HomeViewModel.kt @@ -16,27 +16,22 @@ package com.android.developers.androidify.home import androidx.lifecycle.ViewModel -import androidx.lifecycle.viewModelScope import com.android.developers.androidify.data.ConfigProvider import dagger.hilt.android.lifecycle.HiltViewModel import kotlinx.coroutines.flow.MutableStateFlow import kotlinx.coroutines.flow.asStateFlow -import kotlinx.coroutines.launch import javax.inject.Inject @HiltViewModel -class HomeViewModel @Inject constructor(val configProvider: ConfigProvider) : ViewModel() { - private val _state = MutableStateFlow(HomeState()) +class HomeViewModel @Inject constructor(configProvider: ConfigProvider) : ViewModel() { + private val _state = MutableStateFlow( + HomeState( + isAppActive = !configProvider.isAppInactive(), + dancingDroidLink = configProvider.getDancingDroidLink(), + videoLink = configProvider.getPromoVideoLink(), + ), + ) val state = _state.asStateFlow() - init { - viewModelScope.launch { - _state.value = _state.value.copy( - isAppActive = !configProvider.isAppInactive(), - dancingDroidLink = configProvider.getDancingDroidLink(), - videoLink = configProvider.getPromoVideoLink(), - ) - } - } } data class HomeState(