Skip to content

Code review ideas #20

@andreww

Description

@andreww

Notes from compearthsci code review

  • Add test cases edge cases e.g. negative r, r=0
  • Input argument validation for PREM class
  • Refactoring of EarthModel ... seperate data and "physics" methods, introduce protocol for type checking of model
  • Some issues in tests with linting - use a linter in VS code and check all formatting

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions