Skip to content

"Null" string should be displayed as a string, not as null #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdeniau wants to merge 1 commit into
base: master
Choose a base branch
from
Open

"Null" string should be displayed as a string, not as null #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<head>
<title>Immutable DevTools Demo</title>
<!-- <script src="https://cdnjs.cloudflare.com/ajax/libs/immutable/3.7.6/immutable.min.js"></script> -->
<script src="https://cdnjs.cloudflare.com/ajax/libs/immutable/4.0.0-rc.7/immutable.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/immutable/5.0.3/immutable.js"></script>
<script src="dist/index.js"></script>
<script id="demoScript">
var MyRecord = Immutable.Record({
Expand Down Expand Up @@ -70,6 +70,7 @@
})
console.log('Nested Records', nestedRecords)

console.log("Null string", Immutable.List.of("hello", "null", null, 'undefined', undefined));
</script>
</head>
<body>
Expand Down
2 changes: 1 addition & 1 deletion src/createFormatters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default function createFormatter(Immutable) {
const reference = (object, config) => {
if (typeof object === 'undefined')
return ['span', nullStyle, 'undefined'];
else if (object === 'null')
else if (object === null)
return ['span', nullStyle, 'null'];

return ['object', {object, config}];
Expand Down