Cover legacy conditions (#386)

* [FEATURE] Migrate legacy conditions

* ip
* hostname
* compat version

Author: kitzberger

packages/typo3-fractor/config/typo3-10.php

@@ -4,6 +4,7 @@
 
 use a9f\Typo3Fractor\TYPO3v10\Fluid\RemoveNoCacheHashAndUseCacheHashAttributeFluidFractor;
 use a9f\Typo3Fractor\TYPO3v10\TypoScript\MigrateLegacyTypoScriptConditionsFractor;
+use a9f\Typo3Fractor\TYPO3v10\TypoScript\MigrateTypoScriptPageConditionPipeAccessFractor;
 use a9f\Typo3Fractor\TYPO3v10\TypoScript\RemoveConfigConcatenateJsAndCssFractor;
 use a9f\Typo3Fractor\TYPO3v10\TypoScript\RemoveConfigDefaultGetVarsFractor;
 use a9f\Typo3Fractor\TYPO3v10\TypoScript\RemoveConfigHtmlTagDirFractor;
@@ -38,6 +39,7 @@
     $services->set(RemoveNoCacheHashAndUseCacheHashAttributeFluidFractor::class);
     $services->set(RemoveUseCacheHashFromTypolinkTypoScriptFractor::class);
     $services->set(MigrateLegacyTypoScriptConditionsFractor::class);
+    $services->set(MigrateTypoScriptPageConditionPipeAccessFractor::class);
     $services->set(RemoveConfigConcatenateJsAndCssFractor::class);
     $services->set(RemoveConfigDefaultGetVarsFractor::class);
     $services->set(RemoveConfigHtmlTagDirFractor::class);

packages/typo3-fractor/config/typo3-11.php

@@ -2,6 +2,7 @@
 
 declare(strict_types=1);
 
+use a9f\Typo3Fractor\TYPO3v11\TypoScript\MigrateTypoScriptPageConditionToTraverseFractor;
 use a9f\Typo3Fractor\TYPO3v11\TypoScript\RenameFeLoginSettingShowForgotPasswordLinkFractor;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 
@@ -12,4 +13,5 @@
         ->autowire();
 
     $services->set(RenameFeLoginSettingShowForgotPasswordLinkFractor::class);
+    $services->set(MigrateTypoScriptPageConditionToTraverseFractor::class);
 };

packages/typo3-fractor/docs/typo3-fractor-rules.md

@@ -1,4 +1,4 @@
-# 44 Rules Overview
+# 46 Rules Overview
 
 ## AbstractMessageGetSeverityFluidFractor
 
@@ -461,6 +461,39 @@ Migrate legacy TypoScript conditions to Symfony expression language syntax
 
 <br>
 
+```diff
+-[IP = 123.456.*.*]
++[ip("123.456.*.*")]
+     page = PAGE
+     page.10 = TEXT
+     page.10.value = Visitor IP starts with 123.456
+ [end]
+```
+
+<br>
+
+```diff
+-[hostname = example.org]
++[request.getNormalizedParams().getHttpHost() == "example.org"]
+     page = PAGE
+     page.10 = TEXT
+     page.10.value = Visitor hostname is example.org
+ [end]
+```
+
+<br>
+
+```diff
+-[compatVersion = 9.5.0]
++[compatVersion("9.5.0")]
+     page = PAGE
+     page.10 = TEXT
+     page.10.value = TYPO3 version is at least 9.5.0
+ [end]
+```
+
+<br>
+
 ## MigrateNullFlagFlexFormFractor
 
 Migrate null flag
@@ -711,6 +744,62 @@ Migrate TypoScript loginUser and usergroup conditions (both function-call and eq
 
 <br>
 
+## MigrateTypoScriptPageConditionPipeAccessFractor
+
+Migrate page pipe access in TypoScript conditions to bracket array access syntax
+
+- class: [`a9f\Typo3Fractor\TYPO3v10\TypoScript\MigrateTypoScriptPageConditionPipeAccessFractor`](../rules/TYPO3v10/TypoScript/MigrateTypoScriptPageConditionPipeAccessFractor.php)
+
+```diff
+-[page|uid = 2]
++[page["uid"] == 2]
+     page = PAGE
+     page.10 = TEXT
+     page.10.value = Hello
+ [end]
+```
+
+<br>
+
+```diff
+-[page|layout == 1]
++[page["layout"] == 1]
+     page = PAGE
+     page.10 = TEXT
+     page.10.value = Layout 1
+ [end]
+```
+
+<br>
+
+## MigrateTypoScriptPageConditionToTraverseFractor
+
+Migrate page["field"] to traverse(page, "field") in TypoScript conditions for safe access
+
+- class: [`a9f\Typo3Fractor\TYPO3v11\TypoScript\MigrateTypoScriptPageConditionToTraverseFractor`](../rules/TYPO3v11/TypoScript/MigrateTypoScriptPageConditionToTraverseFractor.php)
+
+```diff
+-[page["uid"] == 1]
++[traverse(page, "uid") == 1]
+     page = PAGE
+     page.10 = TEXT
+     page.10.value = Hello
+ [end]
+```
+
+<br>
+
+```diff
+-[page["backend_layout"] == "pagets__home"]
++[traverse(page, "backend_layout") == "pagets__home"]
+     page = PAGE
+     page.10 = TEXT
+     page.10.value = Home layout
+ [end]
+```
+
+<br>
+
 ## RemoveConfigDisablePageExternalUrlFractor
 
 Remove config.disablePageExternalUrl

packages/typo3-fractor/rules-tests/TYPO3v10/TypoScript/MigrateLegacyTypoScriptConditionsFractor/Fixtures/fixture90.typoscript.fixture

@@ -0,0 +1,11 @@
+[IP = 123.456.*.*]
+    page = PAGE
+    page.90 = TEXT
+    page.90.value = IP match
+[end]
+-----
+[ip("123.456.*.*")]
+    page = PAGE
+    page.90 = TEXT
+    page.90.value = IP match
+[end]

packages/typo3-fractor/rules-tests/TYPO3v10/TypoScript/MigrateLegacyTypoScriptConditionsFractor/Fixtures/fixture91.typoscript.fixture

@@ -0,0 +1,11 @@
+[IP = 192.168.1.*, 10.0.0.*]
+    page = PAGE
+    page.91 = TEXT
+    page.91.value = local network
+[end]
+-----
+[ip("192.168.1.*") || ip("10.0.0.*")]
+    page = PAGE
+    page.91 = TEXT
+    page.91.value = local network
+[end]

packages/typo3-fractor/rules-tests/TYPO3v10/TypoScript/MigrateLegacyTypoScriptConditionsFractor/Fixtures/fixture92.typoscript.fixture

@@ -0,0 +1,11 @@
+[IP = devIP]
+    page = PAGE
+    page.92 = TEXT
+    page.92.value = developer IP
+[end]
+-----
+[ip("devIP")]
+    page = PAGE
+    page.92 = TEXT
+    page.92.value = developer IP
+[end]

packages/typo3-fractor/rules-tests/TYPO3v10/TypoScript/MigrateLegacyTypoScriptConditionsFractor/Fixtures/fixture93.typoscript.fixture

@@ -0,0 +1,11 @@
+[hostname = www.example.org]
+    page = PAGE
+    page.93 = TEXT
+    page.93.value = hostname match
+[end]
+-----
+[request.getNormalizedParams().getHttpHost() == "www.example.org"]
+    page = PAGE
+    page.93 = TEXT
+    page.93.value = hostname match
+[end]

packages/typo3-fractor/rules-tests/TYPO3v10/TypoScript/MigrateLegacyTypoScriptConditionsFractor/Fixtures/fixture94.typoscript.fixture

@@ -0,0 +1,11 @@
+[hostname = *.example.org]
+    page = PAGE
+    page.94 = TEXT
+    page.94.value = wildcard hostname
+[end]
+-----
+[like(request.getNormalizedParams().getHttpHost(), "*.example.org")]
+    page = PAGE
+    page.94 = TEXT
+    page.94.value = wildcard hostname
+[end]

packages/typo3-fractor/rules-tests/TYPO3v10/TypoScript/MigrateLegacyTypoScriptConditionsFractor/Fixtures/fixture95.typoscript.fixture

@@ -0,0 +1,11 @@
+[hostname = www.example.org, login.*.org]
+    page = PAGE
+    page.95 = TEXT
+    page.95.value = multiple hostnames
+[end]
+-----
+[request.getNormalizedParams().getHttpHost() == "www.example.org" || like(request.getNormalizedParams().getHttpHost(), "login.*.org")]
+    page = PAGE
+    page.95 = TEXT
+    page.95.value = multiple hostnames
+[end]

packages/typo3-fractor/rules-tests/TYPO3v10/TypoScript/MigrateLegacyTypoScriptConditionsFractor/Fixtures/fixture96.typoscript.fixture

@@ -0,0 +1,11 @@
+[compatVersion = 9.5.0]
+    page = PAGE
+    page.96 = TEXT
+    page.96.value = TYPO3 9.5+
+[end]
+-----
+[compatVersion("9.5.0")]
+    page = PAGE
+    page.96 = TEXT
+    page.96.value = TYPO3 9.5+
+[end]