[BUGFIX] Make Fractor free from Rector dependencies (#380)

Resolves: #378

Author: simonschaufi

packages/fractor-rule-generator/src/FileSystem/TemplateFileSystem.php

@@ -5,9 +5,9 @@
 namespace a9f\FractorRuleGenerator\FileSystem;
 
 use a9f\Fractor\Exception\ShouldNotHappenException;
+use a9f\Fractor\Testing\PHPUnit\StaticPHPUnitEnvironment;
 use a9f\FractorRuleGenerator\Finder\TemplateFinder;
 use Nette\Utils\Strings;
-use Rector\Testing\PHPUnit\StaticPHPUnitEnvironment;
 use Symfony\Component\Filesystem\Filesystem;
 use Symfony\Component\Finder\SplFileInfo;
 

packages/fractor/src/Configuration/ConfigurationRuleFilter.php

@@ -43,18 +43,18 @@ public function filter(iterable $fractorRules): array
     }
 
     /**
-     * @param list<FractorRule> $rectors
+     * @param list<FractorRule> $fractorRules
      * @return list<FractorRule>
      */
-    public function filterOnlyRule(array $rectors, string $onlyRule): array
+    public function filterOnlyRule(array $fractorRules, string $onlyRule): array
     {
-        $activeRectors = [];
-        foreach ($rectors as $rector) {
-            if ($rector instanceof $onlyRule) {
-                $activeRectors[] = $rector;
+        $rules = [];
+        foreach ($fractorRules as $fractorRule) {
+            if ($fractorRule instanceof $onlyRule) {
+                $rules[] = $fractorRule;
             }
         }
 
-        return $activeRectors;
+        return $rules;
     }
 }

packages/fractor/src/Helper/FileHasher.php

@@ -4,7 +4,7 @@
 
 namespace a9f\Fractor\Helper;
 
-use Rector\Exception\ShouldNotHappenException;
+use a9f\Fractor\Exception\ShouldNotHappenException;
 
 final class FileHasher
 {

packages/fractor/src/Testing/Fixture/FixtureTempFileDumper.php

@@ -15,7 +15,6 @@ final class FixtureTempFileDumper
 
     public static function dump(string $fileContents, string $suffix): string
     {
-        // the "php" suffix is important, because that will hook into \Rector\Application\FileProcessor\PhpFileProcessor
         $temporaryFileName = sys_get_temp_dir() . self::TEMP_FIXTURE_DIRECTORY . '/' . md5(
             $fileContents
         ) . '.' . $suffix;

packages/typo3-fractor/bin/typo3-fractor-init.php

@@ -2,8 +2,8 @@
 
 declare(strict_types=1);
 
+use a9f\Fractor\FileSystem\InitFilePathsResolver;
 use Nette\Utils\FileSystem;
-use Rector\FileSystem\InitFilePathsResolver;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -38,8 +38,8 @@
             return Command::FAILURE;
         }
 
-        $commonRectorConfigPath = $projectDirectory . '/fractor.php';
-        if (file_exists($commonRectorConfigPath)) {
+        $commonFractorConfigPath = $projectDirectory . '/fractor.php';
+        if (file_exists($commonFractorConfigPath)) {
             $output->writeln('Configuration already exists.');
             return Command::FAILURE;
         }
@@ -76,7 +76,7 @@
         $output->writeln(
             '<info>The config is added now. Run "fractor process" command to make Fractor do the work!</info>'
         );
-        FileSystem::write($commonRectorConfigPath, $configContents, null);
+        FileSystem::write($commonFractorConfigPath, $configContents, null);
         return Command::SUCCESS;
     })
     ->run();

packages/typo3-fractor/tests/Functional/Bin/InitCommandTest.php

@@ -4,9 +4,9 @@
 
 namespace a9f\Typo3Fractor\Tests\Functional\Bin;
 
+use a9f\Fractor\FileSystem\InitFilePathsResolver;
 use Nette\Utils\FileSystem;
 use PHPUnit\Framework\TestCase;
-use Rector\FileSystem\InitFilePathsResolver;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -52,8 +52,8 @@ protected function setUp(): void
                     return Command::FAILURE;
                 }
 
-                $commonRectorConfigPath = $projectDirectory . '/fractor.php';
-                if (file_exists($commonRectorConfigPath)) {
+                $commonFractorConfigPath = $projectDirectory . '/fractor.php';
+                if (file_exists($commonFractorConfigPath)) {
                     $output->writeln('Configuration already exists.');
                     return Command::FAILURE;
                 }
@@ -90,7 +90,7 @@ protected function setUp(): void
                 $output->writeln(
                     '<info>The config is added now. Run "fractor process" command to make Fractor do the work!</info>'
                 );
-                FileSystem::write($commonRectorConfigPath, $configContents, null);
+                FileSystem::write($commonFractorConfigPath, $configContents, null);
                 return Command::SUCCESS;
             });
 

phpstan.neon

@@ -8,7 +8,6 @@ parameters:
     paths:
         - src/
         - packages/
-        - ecs.php
         - rector.php
     excludePaths:
         - packages/extension-installer/generated