[FEATURE] Add RemoveDuplicateDoktypeRestrictionConfigurationFractor (#372)

Resolves: sabbelasichon/typo3-rector#4616

Author: simonschaufi

packages/typo3-fractor/config/typo3-14.php

@@ -6,6 +6,7 @@
 use a9f\Typo3Fractor\TYPO3v14\Htaccess\RemoveUploadsFromDefaultHtaccessFractor;
 use a9f\Typo3Fractor\TYPO3v14\TypoScript\MigrateTypoScriptConditionGetTSFEFractor;
 use a9f\Typo3Fractor\TYPO3v14\TypoScript\MigrateTypoScriptGetDataPathFractor;
+use a9f\Typo3Fractor\TYPO3v14\TypoScript\RemoveDuplicateDoktypeRestrictionConfigurationFractor;
 use a9f\Typo3Fractor\TYPO3v14\TypoScript\RemoveExposeNonexistentUserInForgotPasswordDialogSettingInFeLoginFractor;
 use a9f\Typo3Fractor\TYPO3v14\TypoScript\RemoveExternalOptionFromTypoScriptFractor;
 use a9f\Typo3Fractor\TYPO3v14\TypoScript\RemoveFrontendAssetConcatenationAndCompressionFractor;
@@ -28,4 +29,5 @@
     $services->set(MigrateTypoScriptGetDataPathFractor::class);
     $services->set(RemoveExternalOptionFromTypoScriptFractor::class);
     $services->set(RemoveUserTSConfigAuthBeRedirectToURLFractor::class);
+    $services->set(RemoveDuplicateDoktypeRestrictionConfigurationFractor::class);
 };

packages/typo3-fractor/docs/typo3-fractor-rules.md

@@ -1,4 +1,4 @@
-# 39 Rules Overview
+# 40 Rules Overview
 
 ## AbstractMessageGetSeverityFluidFractor
 
@@ -514,6 +514,19 @@ Remove config.spamProtectEmailAddresses with option ascii
 
 <br>
 
+## RemoveDuplicateDoktypeRestrictionConfigurationFractor
+
+Remove mod.web_list.noViewWithDokTypes
+
+- class: [`a9f\Typo3Fractor\TYPO3v14\TypoScript\RemoveDuplicateDoktypeRestrictionConfigurationFractor`](../rules/TYPO3v14/TypoScript/RemoveDuplicateDoktypeRestrictionConfigurationFractor.php)
+
+```diff
+-mod.web_list.noViewWithDokTypes = 1
++-
+```
+
+<br>
+
 ## RemoveExposeNonexistentUserInForgotPasswordDialogSettingInFeLoginFractor
 
 Remove plugin.tx_felogin_login.settings.exposeNonexistentUserInForgotPasswordDialog

packages/typo3-fractor/rules-tests/TYPO3v14/TypoScript/RemoveDuplicateDoktypeRestrictionConfigurationFractor/Fixtures/fixture.typoscript.fixture

@@ -0,0 +1,8 @@
+mod {
+    web_list.noViewWithDokTypes = 1
+    foo = 1
+}
+-----
+mod {
+    foo = 1
+}

packages/typo3-fractor/rules-tests/TYPO3v14/TypoScript/RemoveDuplicateDoktypeRestrictionConfigurationFractor/RemoveDuplicateDoktypeRestrictionConfigurationFractorTest.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+namespace a9f\Typo3Fractor\Tests\TYPO3v14\TypoScript\RemoveDuplicateDoktypeRestrictionConfigurationFractor;
+
+use a9f\Fractor\Testing\PHPUnit\AbstractFractorTestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
+
+final class RemoveDuplicateDoktypeRestrictionConfigurationFractorTest extends AbstractFractorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): \Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixtures', '*.typoscript.fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/fractor.php';
+    }
+}

packages/typo3-fractor/rules-tests/TYPO3v14/TypoScript/RemoveDuplicateDoktypeRestrictionConfigurationFractor/config/fractor.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+use a9f\Fractor\Configuration\FractorConfiguration;
+use a9f\Fractor\ValueObject\Indent;
+use a9f\FractorXml\Configuration\XmlProcessorOption;
+use a9f\Typo3Fractor\TYPO3v14\TypoScript\RemoveDuplicateDoktypeRestrictionConfigurationFractor;
+
+return FractorConfiguration::configure()
+    ->withOptions([
+        XmlProcessorOption::INDENT_CHARACTER => Indent::STYLE_TAB,
+        XmlProcessorOption::INDENT_SIZE => 1,
+    ])
+    ->withRules([RemoveDuplicateDoktypeRestrictionConfigurationFractor::class]);

packages/typo3-fractor/rules/TYPO3v14/TypoScript/RemoveDuplicateDoktypeRestrictionConfigurationFractor.php

@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+namespace a9f\Typo3Fractor\TYPO3v14\TypoScript;
+
+use a9f\Typo3Fractor\AbstractRemoveTypoScriptSettingFractor;
+
+/**
+ * @changelog https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/14.0/Breaking-106949-DuplicateDoktypeRestrictionConfigurationRemoved.html
+ * @see \a9f\Typo3Fractor\Tests\TYPO3v14\TypoScript\RemoveDuplicateDoktypeRestrictionConfigurationFractor\RemoveDuplicateDoktypeRestrictionConfigurationFractorTest
+ */
+final class RemoveDuplicateDoktypeRestrictionConfigurationFractor extends AbstractRemoveTypoScriptSettingFractor
+{
+    protected function getFullOptionName(): string
+    {
+        return 'mod.web_list.noViewWithDokTypes';
+    }
+}