Description what is not good / need to improve:
both material ui & bootstrap - need to use only one
commit messages very short and not informative
there is testing library in package.json but NO TESTS(!) - it's very important https://jkettmann.com/beginners-guide-to-testing-react https://joaoforja.com/blog/recipes-for-testing-react-apps-tl https://kentcdodds.com/blog/common-mistakes-with-react-testing-library
no code formatting: need to use prettier (eslint already exists as part of react-scripts)
it will be good to see some comments in code (not too much)
more info in READ.ME - what project is about, what technologies / libraries are in use / key points & solutions
component's folder name in lover case - ii's a good practice to name folder exact as component (reasons -> Reasons, pagination -> PaginationComponent)
some components (for ex. Reasons) can be split in small sub-components (more readable composition)
try to avoid inline event handlers<button onClick={()=>{history.push('./users')}} />const navigateToUsersPage = ()=> history.push('./users') ... <button onClick={navigateToUsersPage} />PaginationComponent is good)
need to decompose/split server.js into functional parts: queries / routes / route handlers
Reactions are currently unavailable
You can’t perform that action at this time.
what is not good / need to improve:
both material ui & bootstrap - need to use only one
commit messages very short and not informative
there is testing library in package.json but NO TESTS(!) - it's very important
https://jkettmann.com/beginners-guide-to-testing-react
https://joaoforja.com/blog/recipes-for-testing-react-apps-tl
https://kentcdodds.com/blog/common-mistakes-with-react-testing-library
no code formatting: need to use
prettier(eslint already exists as part of react-scripts)it will be good to see some comments in code (not too much)
more info in READ.ME - what project is about, what technologies / libraries are in use / key points & solutions
component's folder name in lover case - ii's a good practice to name folder exact as component (
reasons->Reasons,pagination->PaginationComponent)some components (for ex.
Reasons) can be split in small sub-components (more readable composition)try to avoid inline event handlers
bad:
<button onClick={()=>{history.push('./users')}} />good:
const navigateToUsersPage = ()=> history.push('./users') ... <button onClick={navigateToUsersPage} />(
PaginationComponentis good)need to decompose/split
server.jsinto functional parts: queries / routes / route handlers