From 7e24bea4f5a6926f01da2aaf8f101239bc6364c7 Mon Sep 17 00:00:00 2001 From: Josh Lay Date: Mon, 27 Jan 2025 17:00:04 -0600 Subject: [PATCH 1/2] niccli: don't force vars at role level, use defs --- packer-rocm/playbooks/niccli.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/packer-rocm/playbooks/niccli.yml b/packer-rocm/playbooks/niccli.yml index bb35556..b2e1b21 100644 --- a/packer-rocm/playbooks/niccli.yml +++ b/packer-rocm/playbooks/niccli.yml @@ -1,5 +1,6 @@ --- # yamllint disable rule:line-length +# vim: ft=yaml.ansible - name: "Prepare 'niccli' and driver" hosts: default environment: # may be superfluous for your environment; mapped through Packer HCL with 'ansible_env_vars' @@ -7,9 +8,4 @@ https_proxy: "{{ lookup('ansible.builtin.env', 'https_proxy') | default(omit) }}" no_proxy: "{{ lookup('ansible.builtin.env', 'no_proxy') | default(omit) }}" roles: - - name: Include 'niccli' Role - role: niccli - niccli_url: 'https://docs.broadcom.com/docs-and-downloads/ethernet-network-adapters/NXE/Thor2/GCA2/bcm5760x_231.2.63.0a.zip' - niccli_sum: 'sha256:5c46de9addf9284fb48fef1c505c470c85fd4c129045bdd8ee706447bc1bd025' - -# vim: ft=yaml.ansible + - { role: niccli } From 84e908a36c390c0b571541a507330b08fedfc348 Mon Sep 17 00:00:00 2001 From: Josh Lay Date: Mon, 27 Jan 2025 17:00:59 -0600 Subject: [PATCH 2/2] niccli: bump default --- packer-rocm/playbooks/roles/niccli/defaults/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packer-rocm/playbooks/roles/niccli/defaults/main.yml b/packer-rocm/playbooks/roles/niccli/defaults/main.yml index 897eebc..c4090ea 100644 --- a/packer-rocm/playbooks/roles/niccli/defaults/main.yml +++ b/packer-rocm/playbooks/roles/niccli/defaults/main.yml @@ -9,7 +9,7 @@ # - 'NetXtreme-E Linux Driver' # # NOTE/Warning: Patterns in URLs have not been consistent enough for templating to make [much] sense. Directories change along with releases. -niccli_url: 'https://docs.broadcom.com/docs-and-downloads/ethernet-network-adapters/NXE/Thor2/GCA2/bcm5760x_231.2.63.0a.zip' +niccli_url: 'https://docs.broadcom.com/docs-and-downloads/ethernet-network-adapters/NXE/BRCM_232.1.132.8/bcm_232.1.132.8c.tar.gz' # 'niccli_sum' deliberately is *not* defaulted with the URL. # if users want to change the link... they should not be required to correct or empty the checksum. this should act as opt-in validation, not a requirement.