refactor: shared bulk processor pool sized by cluster CPU count#1555
Merged
refactor: shared bulk processor pool sized by cluster CPU count#1555
Conversation
Move RoutedBulkIndexer pool from per-species to a shared pool managed by SourceDocumentCreationManager. Pool size is dynamically calculated from the ES cluster's total available CPUs * 2, queried via the new _nodes/os endpoint on ElasticSearchInterface. JSONProducer work buckets now use byte-size limit (1MB default) instead of document count, configurable via VARIANT_SOURCE_DOCUMENT_CREATOR_JSON_QUEUE_BUCKET_SIZE. Shared jsonQueue capacity scales with active species count (250 * species). Move ElasticSearchInterface from agr_indexer to agr_java_core for reuse across modules, add getNodesOs() method for cluster info queries.
Code ReviewThis is a clean refactor that moves the bulk indexer pool from per-species to shared management, with dynamic sizing from ES cluster CPU count. The changes look correct. One minor observation (non-blocking): In Everything else looks good:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move RoutedBulkIndexer pool from per-species to a shared pool managed by SourceDocumentCreationManager. Pool size is dynamically calculated from the ES cluster's total available CPUs * 2, queried via the new _nodes/os endpoint on ElasticSearchInterface.
JSONProducer work buckets now use byte-size limit (1MB default) instead of document count, configurable via VARIANT_SOURCE_DOCUMENT_CREATOR_JSON_QUEUE_BUCKET_SIZE.
Shared jsonQueue capacity scales with active species count (250 * species).
Move ElasticSearchInterface from agr_indexer to agr_java_core for reuse across modules, add getNodesOs() method for cluster info queries.