Use Species for allele display names, normalize nameKey field#1540
Merged
Use Species for allele display names, normalize nameKey field#1540
Conversation
Code ReviewChanges look correct. Two small, well-structured changes:
No bugs, no performance concerns, no breaking changes. |
Remove all snake_case name_key references in favor of camelCase nameKey for consistency with curation API document serialization. Updates ES mappings, search queries, boost functions, autocomplete, response fields, document models, and test assertions.
cmpich
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Species.fullNamefor the species field andSpecies.abbreviationfor the nameKey suffix (e.g. "allele (Mmu)") instead of the raw NCBITaxonTerm name. Falls back to taxon name if Species is not available.name_keytonameKeyeverywhere: Remove all snake_casename_keyreferences in favor of camelCasenameKeyfor consistency with curation API document serialization. This includes ES mappings, search queries, boost functions, autocomplete, response fields, document models (@JsonPropertyannotations removed), and test assertions.Files changed
name_keytonameKey@JsonProperty("name_key")annotations and unused imports@DataTest plan
name_keytonameKey)