You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR passes ProcessDisplayHelper as a parameter to the index() method and adds a new startProcess(long totalSize) overload so subclass indexers can report their total item count for progress tracking.
The changes look correct. This is a clean, mechanical refactor applied consistently across all indexer subclasses. A few observations:
Double startProcess is fine: The base class calls display.startProcess(className) (sets the message label), then subclasses call display.startProcess(totalSize) (sets the total count while preserving the message). Since no processing occurs between the two calls, the counter reset is harmless.
Inconsistent coverage: Some indexers (DatasetIndexer, DiseaseIndexer, GeneIndexer, GoIndexer, LiteratureIndexer, VariantIndexer, DiseaseAnnotationCurationIndexer, PhenotypeAnnotationCurationIndexer, ReleaseInfoIndexer, SiteMapAccessionCurationIndexer, GeneExpressionRibbonSummaryIndexer) accept the display parameter but never call display.startProcess(totalSize). This means they won't report total counts or show progress percentages/ETAs. This may be intentional (some don't have an easily available count), but worth confirming.
Redundant parameter: The display field is already inherited from the Indexer base class, so passing it as a method parameter is technically redundant — subclasses could access it directly. Not a problem, just a design note.
No bugs, no security concerns, no performance issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.