SCRUM-5829 collate both SGD spcies into a single species facet#1537
SCRUM-5829 collate both SGD spcies into a single species facet#1537
Conversation
Code ReviewChanges reviewed: Verdict: Looks good. The logic is correct and the null guard is appropriate. The normalization is applied consistently at all three places where One minor note: the second call to This is consistent with the existing reverse-mapping pattern already in |
| NCBITaxonTerm taxon = allele.getTaxon(); | ||
| if (taxon != null) { | ||
| searchDoc.setSpecies(taxon.getName()); | ||
| String speciesName = normalizeSpeciesName(taxon.getName()); |
There was a problem hiding this comment.
speciesName needs to be allele.getTaxon().getSpecies().getName() and we need to revert the SGD special handling of the name.
There was a problem hiding this comment.
We are going to need to do this story: https://agr-jira.atlassian.net/browse/SCRUM-2758 to get rid of this issue.
No description provided.