Skip to content

feat: add diseasesWithParents to allele search results (SCRUM-5829)#1536

Merged
oblodgett merged 3 commits intostagefrom
SCRUM-5829
Mar 26, 2026
Merged

feat: add diseasesWithParents to allele search results (SCRUM-5829)#1536
oblodgett merged 3 commits intostagefrom
SCRUM-5829

Conversation

@oblodgett
Copy link
Copy Markdown
Member

Summary

  • Add diseasesWithParents field to AlleleSearchResultDocument and copy it from AlleleSummaryDocument in the converter
  • Reorder AlleleSummaryCurationIndexer to convert derived documents first, then strip transport-only fields via removeTransportFields() before indexing summary documents to ES

Context

Companion to agr_curation release/v0.47.12. The curation side populates diseasesWithParents on the summary document; this change ensures it flows through to the AlleleSearchResultDocument in ES, enabling disease→allele related data links in search results.

Test plan

  • Deploy to stage
  • Reindex after curation release deploys
  • Verify allele search result documents in ES contain diseasesWithParents
  • Verify disease search results show Allele related data links

Add diseasesWithParents field to AlleleSearchResultDocument and copy
it from AlleleSummaryDocument in the converter. Reorder indexer to
convert derived documents before stripping transport-only fields
from summary documents.
@oblodgett oblodgett requested a review from a team as a code owner March 26, 2026 03:40
@claude
Copy link
Copy Markdown

claude bot commented Mar 26, 2026

Code Review

Changes reviewed: 3 files — adds diseasesWithParents field to allele search results and reorders indexing to convert derived documents before stripping transport-only fields.

Verdict: Looks good.

The changes are clean and follow existing patterns:

  1. Indexer reordering (AlleleSummaryCurationIndexer.java): The new order (convert → strip → index) correctly ensures derived documents consume transport fields before they're removed. This is a necessary fix — without it, diseasesWithParents (and potentially other transport-only fields) would be stripped before the converters could read them.

  2. Converter (AlleleSearchResultConverter.java): The new diseasesWithParents copy follows the identical null/empty guard pattern used for diseasesAgrSlim right above it.

  3. Document model (AlleleSearchResultDocument.java): Simple field addition with Lombok handling getters/setters.

No correctness issues, no performance concerns, no security problems found.

@oblodgett oblodgett merged commit 76a40b7 into stage Mar 26, 2026
5 checks passed
@oblodgett oblodgett deleted the SCRUM-5829 branch March 26, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants