You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary: Library upgrade from v0.47.6 to v0.47.9, adapting to API changes (TransgenicAlleleDTO → TransgenicAlleleDocument, construct access pattern change), adding construct component fields to allele search, and a new species null check.
Bug: getFirst() on potentially empty/null construct list
The old code called da.getConstruct() (single object). The new code calls da.getConstructList().getFirst(), which will throw:
NullPointerException if getConstructList() returns null
NoSuchElementException if the list is empty
There is no guard before this call. Consider adding a null/empty check (similar to the existing da == null check above), or using a safer access pattern.
If da.getAllele() or da.getAllele().getTaxon() is null, this will throw a NullPointerException. The existing null check only covers da itself. If the upstream data guarantees these are never null, this is fine — but it's worth confirming given this is indexer code processing bulk data.
Rest of the changes look correct
The new construct component fields in AlleleSearchResultDocument and their population in AlleleSearchResultConverter are straightforward additions with proper null/empty guards.
Method reference refactors (NameSlotAnnotation::getDisplayText, Objects::nonNull) are clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.