Skip to content

Updated autocomplete to fix genes#1533

Merged
oblodgett merged 2 commits intostagefrom
SCRUM-4816
Mar 24, 2026
Merged

Updated autocomplete to fix genes#1533
oblodgett merged 2 commits intostagefrom
SCRUM-4816

Conversation

@oblodgett
Copy link
Copy Markdown
Member

No description provided.

@oblodgett oblodgett requested a review from a team as a code owner March 23, 2026 16:41
@claude
Copy link
Copy Markdown

claude bot commented Mar 23, 2026

Code Review

Changes look correct. Two Java files modified to fix gene autocomplete results:

  1. AutoCompleteDAO.java: Added curie and nameKey to the Elasticsearch response fields. Reordered but no fields were dropped — name_key is still fetched alongside the new nameKey.

  2. AutoCompleteService.java: For gene results, maps nameKeyname_key (similar to the existing symbolname mapping). Removed unused SearchHelper import and field — clean cleanup.

One minor note: if a gene document has a null nameKey in ES, line 84 would overwrite whatever name_key value was already in the source map with null. If that scenario is possible and name_key has a valid fallback value in the document, a null-check guard would be safer. If gene documents always have nameKey populated, this is fine as-is.

No security, performance, or API-breaking concerns.

@oblodgett oblodgett merged commit 39f9e07 into stage Mar 24, 2026
5 checks passed
@oblodgett oblodgett deleted the SCRUM-4816 branch March 24, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants