You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Changes look correct. Two Java files modified to fix gene autocomplete results:
AutoCompleteDAO.java: Added curie and nameKey to the Elasticsearch response fields. Reordered but no fields were dropped — name_key is still fetched alongside the new nameKey.
AutoCompleteService.java: For gene results, maps nameKey → name_key (similar to the existing symbol → name mapping). Removed unused SearchHelper import and field — clean cleanup.
One minor note: if a gene document has a null nameKey in ES, line 84 would overwrite whatever name_key value was already in the source map with null. If that scenario is possible and name_key has a valid fallback value in the document, a null-check guard would be safer. If gene documents always have nameKey populated, this is fine as-is.
No security, performance, or API-breaking concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.