Skip to content

Commit 802c5a2

Browse files
authored
Merge pull request #1547 from alliance-genome/SCRUM-5953
Switch out download files for Species full name
2 parents d9c4fdf + c3702cc commit 802c5a2

File tree

8 files changed

+12
-12
lines changed

8 files changed

+12
-12
lines changed

agr_api/src/main/java/org/alliancegenome/api/service/ExpressionRibbonESService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ private RibbonEntity getExpressionRibbonSummary(String geneID) {
153153
dataProvider = annotation.getDataProvider().getAbbreviation();
154154
entity.setLabel(gene.getGeneSymbol().getDisplayText());
155155
entity.setTaxonID(gene.getTaxon().getCurie());
156-
entity.setTaxonName(gene.getTaxon().getName());
156+
entity.setTaxonName(gene.getTaxon().getSpecies().getFullName());
157157
} else {
158158
Map<String, Object> geneDoc = getGene(geneID);
159159
SpeciesType type = SpeciesType.getTypeByNameField(geneDoc.get("species").toString());

agr_api/src/main/java/org/alliancegenome/api/translators/tdf/DiseaseAnnotationToTdfTranslator.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,19 +191,19 @@ private static void extracted(DiseaseAnnotationDocument annotation, org.alliance
191191
if (annotation instanceof GeneDiseaseAnnotationDocument document) {
192192
org.alliancegenome.curation_api.model.entities.Gene subject = document.getSubject();
193193
subjectTaxonCurie = subject.getTaxon().getCurie();
194-
subjectTaxonName = subject.getTaxon().getName();
194+
subjectTaxonName = subject.getTaxon().getSpecies().getFullName();
195195
subjectID = subject.getIdentifier();
196196
subjectSymbol = subject.getGeneSymbol().getDisplayText();
197197
} else if (annotation instanceof AlleleDiseaseAnnotationDocument document) {
198198
org.alliancegenome.curation_api.model.entities.Allele subject = document.getSubject();
199199
subjectTaxonCurie = subject.getTaxon().getCurie();
200-
subjectTaxonName = subject.getTaxon().getName();
200+
subjectTaxonName = subject.getTaxon().getSpecies().getFullName();
201201
subjectID = subject.getIdentifier();
202202
subjectSymbol = subject.getAlleleSymbol().getDisplayText();
203203
} else if (annotation instanceof AGMDiseaseAnnotationDocument document) {
204204
org.alliancegenome.curation_api.model.entities.AffectedGenomicModel subject = document.getSubject();
205205
subjectTaxonCurie = subject.getTaxon().getCurie();
206-
subjectTaxonName = subject.getTaxon().getName();
206+
subjectTaxonName = subject.getTaxon().getSpecies().getFullName();
207207
subjectID = subject.getIdentifier();
208208
subjectSymbol = subject.getAgmFullName().getDisplayText();
209209
row.setEntityType(subject.getSubtype().getName());

agr_api/src/test/java/org/alliancegenome/api/tests/integration/GeneIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ public void checkExpressionAnnotation() {
176176
String terms = String.join(",", termList);
177177
// String stages = String.join(",", stageList);
178178
String symbols = String.join(",", symbolList);
179-
assertThat("first element species", response.getResults().get(0).getGeneExpressionAnnotation().getExpressionAnnotationSubject().getTaxon().getName(), equalTo("Danio rerio"));
179+
assertThat("first element species", response.getResults().get(0).getGeneExpressionAnnotation().getExpressionAnnotationSubject().getTaxon().getSpecies().getFullName(), equalTo("Danio rerio"));
180180
assertThat("first element symbol", response.getResults().get(0).getGeneExpressionAnnotation().getExpressionAnnotationSubject().getGeneSymbol().getDisplayText(), equalTo("abcb4"));
181181
assertThat("list of terms", terms, equalTo("bile canaliculus,head,head,head,head,head,head,head,head,hepatocyte intracellular canaliculus,intestinal bulb,intestine,intestine,intestine,intestine"));
182182
// assertThat("list of stages", stages, equalTo("ZFS:0000029,ZFS:0000030,ZFS:0000031,ZFS:0000032,ZFS:0000033,ZFS:0000034,ZFS:0000035,ZFS:0000036,ZFS:0000037,ZFS:0000029,ZFS:0000030,ZFS:0000031,ZFS:0000032,ZFS:0000033,ZFS:0000034"));
@@ -261,7 +261,7 @@ public void checkExpressionAnnotationFilter() {
261261
String terms = String.join(",", termList);
262262
// String stages = String.join(",", stageList);
263263
String symbols = String.join(",", symbolList);
264-
assertThat("first element species", response.getResults().get(0).getGeneExpressionAnnotation().getExpressionAnnotationSubject().getTaxon().getName(), equalTo("Danio rerio"));
264+
assertThat("first element species", response.getResults().get(0).getGeneExpressionAnnotation().getExpressionAnnotationSubject().getTaxon().getSpecies().getFullName(), equalTo("Danio rerio"));
265265
assertThat("first element symbol", response.getResults().get(0).getGeneExpressionAnnotation().getExpressionAnnotationSubject().getGeneSymbol().getDisplayText(), equalTo("shha"));
266266
assertThat("list of terms", terms, equalTo("anal fin,anterior neural keel,anterior neural keel ventral region,anterior neural rod,axial chorda mesoderm,axial chorda mesoderm"));
267267
// assertThat("list of stages", stages, equalTo("ZFS:0000029,ZFS:0000030,ZFS:0000031,ZFS:0000032,ZFS:0000033,ZFS:0000034,ZFS:0000035,ZFS:0000036,ZFS:0000044"));

agr_java_core/src/main/java/org/alliancegenome/core/translators/tdf/AlleleToTdfTranslator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@
1616
import org.alliancegenome.curation_api.model.entities.Allele;
1717
import org.alliancegenome.curation_api.model.entities.CrossReference;
1818
import org.alliancegenome.curation_api.model.entities.Note;
19+
import org.alliancegenome.curation_api.model.entities.PredictedVariantConsequence;
1920
import org.alliancegenome.curation_api.model.entities.Reference;
2021
import org.alliancegenome.curation_api.model.entities.TransgenicAlleleConstruct;
2122
import org.alliancegenome.curation_api.model.entities.Variant;
22-
import org.alliancegenome.curation_api.model.entities.PredictedVariantConsequence;
2323
import org.alliancegenome.curation_api.model.entities.associations.CuratedVariantGenomicLocationAssociation;
2424
import org.alliancegenome.curation_api.model.entities.associations.TranscriptGeneAssociation;
2525
import org.alliancegenome.curation_api.model.entities.ontology.SOTerm;
@@ -163,7 +163,7 @@ private TransgenicAlleleDownloadRow getBaseDownloadAlleleTransgenicRow(Transgeni
163163
TransgenicAlleleDownloadRow row = new TransgenicAlleleDownloadRow();
164164
Allele allele = transgenicAlleleSummaryDocument.getAllele();
165165

166-
row.setSpecies(allele.getTaxon().getName());
166+
row.setSpecies(allele.getTaxon().getSpecies().getFullName());
167167
row.setAlleleID(allele.getPrimaryExternalId());
168168
row.setAlleleSymbol(allele.getAlleleSymbol().getFormatText());
169169
row.setTgConstructID(transgenicAlleleConstruct.getConstruct().getPrimaryExternalId());

agr_java_core/src/main/java/org/alliancegenome/core/translators/tdf/ExpressionToTdfTranslator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ private String buildRow(
5959
StringJoiner joiner = new StringJoiner("\t");
6060
if (isMultipleGenes) {
6161
var subject = annotation.getExpressionAnnotationSubject();
62-
joiner.add(subject.getTaxon().getName())
62+
joiner.add(subject.getTaxon().getSpecies().getFullName())
6363
.add(subject.getGeneSymbol().getDisplayText())
6464
.add(subject.getPrimaryExternalId());
6565
}

agr_java_core/src/main/java/org/alliancegenome/core/translators/tdf/GeneGeneticInteractionToTdfTranslator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public String getAllRows(List<GeneGeneticInteractionDocument> interactions) {
5656
joiner.add(interaction.getGeneGeneticInteraction().getGeneGeneAssociationObject().getIdentifier());
5757
joiner.add(interaction.getGeneGeneticInteraction().getGeneGeneAssociationObject().getGeneSymbol().getDisplayText());
5858
joiner.add(interaction.getGeneGeneticInteraction().getGeneGeneAssociationObject().getTaxon().getCurie());
59-
joiner.add(interaction.getGeneGeneticInteraction().getGeneGeneAssociationObject().getTaxon().getName());
59+
joiner.add(interaction.getGeneGeneticInteraction().getGeneGeneAssociationObject().getTaxon().getSpecies().getFullName());
6060

6161
joiner.add(interaction.getGeneGeneticInteraction().getInteractorBType().getCurie());
6262
joiner.add(interaction.getGeneGeneticInteraction().getInteractorBType().getName());

agr_java_core/src/main/java/org/alliancegenome/core/translators/tdf/GeneMolecularInteractionToTdfTranslator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public String getAllRows(List<GeneMolecularInteractionDocument> interactions) {
5656
joiner.add(interaction.getGeneMolecularInteraction().getGeneGeneAssociationObject().getIdentifier());
5757
joiner.add(interaction.getGeneMolecularInteraction().getGeneGeneAssociationObject().getGeneSymbol().getDisplayText());
5858
joiner.add(interaction.getGeneMolecularInteraction().getGeneGeneAssociationObject().getTaxon().getCurie());
59-
joiner.add(interaction.getGeneMolecularInteraction().getGeneGeneAssociationObject().getTaxon().getName());
59+
joiner.add(interaction.getGeneMolecularInteraction().getGeneGeneAssociationObject().getTaxon().getSpecies().getFullName());
6060

6161
joiner.add(interaction.getGeneMolecularInteraction().getInteractorBType().getCurie());
6262
joiner.add(interaction.getGeneMolecularInteraction().getInteractorBType().getName());

agr_java_core/src/main/java/org/alliancegenome/core/variant/converters/VariantSearchResultConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public List<VariantSearchResultDocument> convertToVariantSearchDocument(List<Var
3232

3333
if (variantLocation.getVariantAssociationSubject() != null) {
3434
if (variantLocation.getVariantAssociationSubject().getTaxon() != null) {
35-
vsd.setSpecies(variantLocation.getVariantAssociationSubject().getTaxon().getName());
35+
vsd.setSpecies(variantLocation.getVariantAssociationSubject().getTaxon().getSpecies().getFullName());
3636
}
3737
if (variantLocation.getVariantAssociationSubject().getVariantType() != null && variantLocation.getVariantAssociationSubject().getVariantType().getName() != null) {
3838
vsd.setVariantType(List.of(variantLocation.getVariantAssociationSubject().getVariantType().getName()));

0 commit comments

Comments
 (0)