Purpose of sleep

[Immortalin]

What is the purpose of

winrt-notification/src/lib.rs

Line 335 in f7879fd

std::thread::sleep(std::time::Duration::from_millis(10));

?

Is the toast notification function not blocking?

[allenbenz]

There's a race where if the application closes before some part of the internal toast process (non-application layer) completes the toast won't get shown. The window is small and the 10ms wait satisfies the race condition.

So in a long running program this isn't required. Though Toasts are rate limited so the wait shouldn't be too big of an issue for most applications.

You can reproduce the issue by running the tests/examples with the sleep removed, the toast will sometimes not appear (or never appear)

[Immortalin]

Shouldn't it return a Future<Result> then? The caller can choose whether they want to block on the thread.

[polarathene]

Probably useful to add an inline note about that for anyone else curious about that line 😅