From 7f4c49cd36388db32ec9007968f458b784df4021 Mon Sep 17 00:00:00 2001 From: mikeabdullah Date: Thu, 28 Apr 2011 03:15:15 -0700 Subject: [PATCH 1/2] Fix potential crash is delegate outlives the view --- Classes/PXListView.m | 1 + 1 file changed, 1 insertion(+) diff --git a/Classes/PXListView.m b/Classes/PXListView.m index fb802c5..dce17d0 100644 --- a/Classes/PXListView.m +++ b/Classes/PXListView.m @@ -72,6 +72,7 @@ - (void)awakeFromNib - (void)dealloc { + [self setDelegate:nil]; // otherwise delegate is left observing notifications from deallocated PXListView [[NSNotificationCenter defaultCenter] removeObserver:self]; [_reusableCells release], _reusableCells = nil; From 3842f95e0e807236a199000ff1adb96890d5b3f6 Mon Sep 17 00:00:00 2001 From: mikeabdullah Date: Thu, 28 Apr 2011 03:16:53 -0700 Subject: [PATCH 2/2] I'm a fussy git who likes less code --- Classes/PXListView.m | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/Classes/PXListView.m b/Classes/PXListView.m index fb802c5..675fbcc 100644 --- a/Classes/PXListView.m +++ b/Classes/PXListView.m @@ -84,11 +84,7 @@ - (void)dealloc #pragma mark - #pragma mark Data Handling -- (id)delegate -{ - return _delegate; -} - +@synthesize delegate = _delegate; - (void)setDelegate:(id)delegate { [_delegate removeObserver:_delegate