When opening multiple frames with dirvish preview window flickers

[emenel]

I'm attempting to setup dirvish as my main file manager (Nixos/Wayland/Niri) and it's generally working well far, but there is one display issue.

When I open two (or more) emacsclient frames the preview window begins to flicker.

There is a thread about it here as well: doomemacs/doomemacs#8355 (comment)

To reproduce:

• Open emacsclient
• start dirvish
• open a second emacsclient frame
• start dirvish in second frame

I'm using:

• Emacs 30.2 pgtk
• Doom
• Wayland/Niri

Thanks for any help sorting this out.

[fuyu0425]

Same issue too.

• archlinux
• emacsclient in terminal mode in ssh + tmux
• emacs-30

[fuyu0425]

I don't know the implications of this, but it works for me to stop flickers in two different frames with preview and still works.
I only try very basic usage, like navigating through files.
By adding (when (eq (frame-selected-window) window) check.

(defun dirvish-pre-redisplay-h (window)
  "Record root WINDOW and redisplay sessions in selected frame."
  (when (eq (frame-selected-window) window)
    (setq dirvish--selected-window (frame-selected-window))
    (when-let* ((dv (dirvish-curr))) (setf (dv-root-window dv) window))
    (dirvish--redisplay)))

When I log the window with two dervish with preview, I found that the window (the argument of dirvish-pre-redisplay-h) keeps jumping between them and thus causes redisplaying and flickering.