Added stop and trailing stop (limit) order templates with validation#322
Open
pssolanki111 wants to merge 2 commits intoalexgolec:masterfrom
Open
Added stop and trailing stop (limit) order templates with validation#322pssolanki111 wants to merge 2 commits intoalexgolec:masterfrom
pssolanki111 wants to merge 2 commits intoalexgolec:masterfrom
Conversation
Contributor
pssolanki111
commented
Aug 29, 2022
pssolanki111
commented
- equity stop
- equity stop limit
- equity trailing stop
- equity trailing stop limit
- Basic validation in the templates.
- relevant docs changes
swickenburg
reviewed
Jan 12, 2023
| raise ValueError('When using percent, trailing offset must be >=1 and <=99') | ||
|
|
||
| return (OrderBuilder() | ||
| .set_order_type(OrderType.TRAILING_STOP) |
There was a problem hiding this comment.
Suggested change
| .set_order_type(OrderType.TRAILING_STOP) | |
| .set_order_type(OrderType.TRAILING_STOP_LIMIT) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.