holes in visualization

[alex-berman]

There are sometimes tiny "holes" in the visualization of fully downloaded files. The reason seems to be that some chunks are not sonified, and therefore not visualized: the first chunk for each player and chunks skipped due to "slow rate" (see WavPlayer).

[alex-berman]

After overlap tolerance was added, the few remaining holes seems to appear only in the beginning or end of each file. This problem has appeared when playing DJ Shadow's Hidden Transmission, containing 3 audio and several non-audio files.

Hypothesis: when receiving a chunk for file X, it may also contain bytes belonging to the next file Y (or hypothetically several other files, although this is very unlikely). If Transmission accommodates this overlap, but we don't, then this would lead to a hole at the beginning of Y. (Additionally, if X is a non-audio file, we ignore it entirely.)

[alex-berman]

It happened again, with http://thepiratebay.se/torrent/7441108/ChesterFrench-BitTorrent

[alex-berman]

No, it was OK after completing the playback...

[alex-berman]

Happens sometimes with TDL4

[alex-berman]

Hopefully solved in f07a3d8

[alex-berman]

A problem may still exist in visualizations where segments are not gathered in the same order as they are played back (due to varying durations). I don't believe that order should matter, but fixing it seems to have solved the problem in the waves visuals (see ea9aa4c).