TV input options "width" and "height" - only default?

[Mark-H]

I set a width and height in the back-end, which I would expect to be enforced when cropping an image.

When I enlarge the cropping area, it does not seem to stick to the width and height I defined but whatever I cropped to is used. This is a dealbreaker when it comes to letting clients manage images in certain parts of the template.

[alanpich]

Most certainly a dealbreaker... and certainly not how it's been working for me. Is this from the Extras repository or the latest git? Any particular steps i should take to reproduce, or as simple as stated above?

[MokoJumbie]

I did some testing on this one. If you select an image, save the page and then reload, you'll get the correct cropping options. Now select a new image with different proportions for the same TV. You'll see the bug. It may have to do with the point at which you're calculating the image dimensions. Hope that helps!

[MokoJumbie]

Reporting back some findings:

I think there are some issues with the this.updateSourceImage function.

• The values for data.image_width and data.image_height are based on the pre-cropped thumbnail width and height. This width is limited to 800px and the height limited to 600px. This is based on the following lines in /core/model/modx/sources/modfilemediasource.class.php:

$imageWidth = $size[0] > 800 ? 800 : $size[0];
$imageHeight = $size[1] > 600 ? 600 : $size[1];

...so when the function resets the crop width and height to these values, they are incorrect.

Assuming the initial width and height are less than 800 and 600 respectively, the image size will be set correctly and so, then, will the initial crop. I realize it's being handled this way so that the initial uncropped image dimensions are being set correctly, but the TV continues to be restricted to this aspect ratio until page reload, when the values defined in the TV config are correctly used.

• The x and y crop coordinates are not being reset on source change.

Hope this helps. Let me know if you have questions.