save-export-clean should flatten

[akkana]

Several people have commented that save-export-clean saves only the current layer. If there are multiple layers and we're saving to a format other than XCF, we should flatten. Preferably without pestering the user with dialogs, because if we're saving to jpg, of course we want to flatten, duh!

[asiga]

Somehow I believe it's better not to flatten. If you've layers and you save to a non-XCF format, that's an error. Now I believe it would be better to just prompt a notice dialog, rather than a Accept/Cancel dialog.

For example, if you save a layered image to non-XCF, I believe it would be wise to just display a notice like this: "You saved a layered image in a format which doesn't support layers. Only the current layer was saved."

I don't think such notice is an annoyance, because it's only displayed if you forget to flatten, and the user is expected to not forget to flatten (at least I'm the kind of user who prefers non-automagical software, so I wouldn't like to have a silent flattening without my consent :-)

(Btw, I'm assuming it saves all layers when you save to XCF, but I'm not sure, since the call to the save function has a drawable argument anyway, so I don't know if such drawable argument is ignored when saving to XCF, or if you've to use another function for saving to XCF)

[MrMoose]

Let me just add a great big thanks!
Ever since Gimp changed it's default behavior to export instead of save I was mighty annoyed by this and never got used to it. So today I finally took to search the web to see if other feel the same and surprise! They do, and there's even a solution. Thanks for this script! Awesome.

[HybridDog]

Some time ago l avoided updating my gimp version from 2.6 to 2.8 mainly because l used gimp to edit textures and it was very useful that l only needed to open one, draw a few lines, hit ctrl+s and close to edit it. But then l switched to 2.8 because G'MIC didn't longer work right l think.
A few days ago l disabled the warning message which told me to save the file before closing. Now l can enable this setting again, thanks to the clean export plug-in.
What is the difference between what Saver and Save/Export clean do?

[akkana]

The page linked off the README describes the difference between the two.
http://www.shallowsky.com/software/gimp-save/

[HybridDog]

So Saver is newer than Save/Export clean?

[akkana]

Yes. I thought that was clear from "But I found that I wasn't using Save/export clean much myself, and eventually, I wrote a more general plug-in called Saver." Is there a way I could rephrase that to make it more clear?

[HybridDog]

in the README the save-export-clean.py has this in its description For people who dislike the Save vs. Export split introduced in 2.8., so l didn't know if that also belongs to the saver plug-in, maybe you could write that save-export-clean is something like an alternative to saver

[akkana]

I've changed it to this:

save-export-clean.py
Save or export, marking the current image clean.
This was an initial quick hack for people who dislike the Save vs. Export
split introduced in GIMP 2.8; it's mostly obsoleted now by Saver.

Is that clearer?

[HybridDog]

yes, thanks