-
Notifications
You must be signed in to change notification settings - Fork 72
Open
Description
Summary
Following the addition of workspace validation to CloudConnection in #929, we should evaluate whether similar validation should be added to CloudSource and CloudDestination classes.
Background
PR #929 added:
check_is_valid()method toCloudConnectionto verify the connection exists and belongs to the expected workspaceAirbyteWorkspaceMismatchErrorexception (generic, designed to work with connections, sources, and destinations)- Updated
_fetch_connection_info()withforce_refreshandverifyparameters
The exception was intentionally designed to be generic (with resource_type and resource_id fields) to support future use with sources and destinations.
Proposed Work
- Evaluate if
CloudSourceandCloudDestinationclasses would benefit from similarcheck_is_valid()methods - If so, implement workspace validation using the existing
AirbyteWorkspaceMismatchErrorexception - Update
_fetch_connector_info()methods with similarforce_refreshandverifyparameters
Timeline
Evaluate after ~1 month of usage to gather feedback on the CloudConnection implementation.
Requested by @aaronsteers
Metadata
Metadata
Assignees
Labels
No labels