Marker thickness selector doesn't highlight the correct value when restoring state

[rjmccluskey]

Hello again! Thanks for you help on previous issues!

I have another small bug to report. With the editor opened from restored state, I noticed that the marker thickness toolbar always selects the middle value even if the marker has a different thickness. The actual thickness of the marker is restored correctly, so it's just a UI bug with the toolbar. You can easily recreate this using your restored state demo. I've also included a video that shows the behavior.

Screen.Recording.2025-04-30.at.12.09.45.PM.mov

[ailon]

Hey @rjmccluskey,

Thank you for reporting this!

The good news is that I see the issue and was able to identify what causes it. The bad news is that it's not limited to stroke width, but the same problem is present in every property panel.

And unfortunately, it's kind of "by design." Not that it's the correct behavior but just that by design panels set the values on the markers and not the other way around. So, when a marker is restored, the panel is in its default state and only changes after user interaction. Fixing this would require changing all the panels and all the code that creates those panels. Meaning that it would require touching almost every file in the codebase.

It doesn't seem like a conceptually complicated fix but it's a cosmetic bug that no one reported in 5 years (ha!). I'm a little wary of potentially introducing a more serious issue by changing how something works fundamentally this late in the product's lifecycle.

I'll think about it and definitely put this on the to-do list but I'm not going to jump straight into fixing it right away. Thank you for understanding!

[rjmccluskey]

Thanks for the reply!

I understand how sometimes design choices make it hard to change things later and I don't blame you for not wanting to do a huge refactor. While it's just a cosmetic bug, we've had users complain that it was a confusing experience. If you feel up to fixing it we'd appreciate it!

panels set the values on the markers and not the other way around

I noticed that when adding new markers if you reselect them during the same session the panel chooses the correct value in the thickness picker. So at least from the outside it seems there is some way that markers are affecting the panel. Is it possible to update the panel on marker select?

[ailon]

I noticed that when adding new markers if you reselect them during the same session the panel chooses the correct value in the thickness picker.

That's because each marker holds its own instance of panel so technically these are not the "values" changing in the panel but a different instance of the panel that keeps that value during the session.

[rjmccluskey]

I see, thanks for the explanation :)