Skip to content

Use soft fail for onchain messaging #60

@whoabuddy

Description

@whoabuddy

We should soft-fail on detecting who the message is from instead of failing the whole transaction.

If you try to send a message with isFromDao set to true and it's not - it will fail.

We can change that check and add the check in #59 for token holder as soft fails that default to false.

That way the TX always goes through but in order to be from the dao or from a token holder must pass a check.

This will also simplify the function call so you don't have to specify who it's from, it'll be in order of:

  • isFromDao (top priority/match)
  • isFromHolder (next match)
  • unverified message (default)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions