How to ert test ekg-denote package

[jayrajput]

I have been working on ekg-denote, a package which export/import between ekg notes and denotes. I have been struggling to write good ert test cases. Any guidance on the same is much appreciated?

[ahyatt]

Exciting to see the progress here! To have easier testing, it's nice have isolated functions that just do the transformation to and from denote, as well as any other interesting logic to test. So, keep the basic logic simple and put the actual file reading and writing there, and do most of the work in testable functions. I think ekg-logseq-tests show some of this, although I could have done a better job in extracting more of the logic to testable classes.

[jayrajput]

Thanks. This is helpful. Let me do that and do some testing.

[jayrajput]

ekg-deftest defined in the ekg-test-utils.el is interesting. It creates a temporary ekg-db file and was what I was looking for my use case. I probably needs something which similarly wraps the denote directory.

[ahyatt]

Sorry for the long period of inactivity on my side, @jayrajput, I was busy with a new job. I've renamed the develop branch to denote-export, since it just had your changes. However, the changes are not passing tests or lint (I'm using eldev to run this). I may have time in the future to look at this, but I don't have time right now, so if you still want to work on this, you can look at the failures in that branch.

[jayrajput]

Let me take a look at the same. I have been using the denote export fine for a while on my local personal system.

[jayrajput]

I found the lint errors with the code comments. Let me fix that. I will send a new Pull Request is what I believe.

[00:00.082]  Linting file ‘ekg-denote.el’
[00:00.094]  ekg-denote.el:38: You should have a section marked ";;; Code:"
[00:00.094]  ekg-denote.el:26: There should be two spaces after a period
[00:00.094]  ekg-denote.el:27: There should be two spaces after a period
[00:00.095]  ekg-denote.el:21: There should be two spaces after a period
[00:00.097]  ekg-denote.el:95: First line is not a complete sentence
[00:00.098]  ekg-denote.el:141: Documentation strings should not start or end with whitespace
[00:00.099]  ekg-denote.el:162: First sentence should end with punctuation
[00:00.101]  ekg-denote.el:192: Error messages should *not* end with a period
[00:00.102]  Found 8 warnings in file ‘ekg-denote.el’