Notes Missing Creation Time

[jayrajput]

I found some of my notes are missing creation time? Is it expected? How can I enforce creation-time for all the notes?

33542768887

[jayrajput]

I also realized that I cannot browse these notes using ekg-show-notes command as well.

Wrong type argument: number-or-marker-p, nil [3 times]

I have been hacking on my system. So it is possible that I have done something wrong. Although I cannot quite pinpoint on what wrong I did.

Is there a way to find such notes and then add creation-time to all of them?

[ahyatt]

I just did a query and didn't see anything like this on my machine. Although you can solve this with just SQL, I think it's a little clearer to use elisp. You can run the following, which should work but I don't have the problem to test against:

;; Note any fix any notes that have a modification time but not a creation time.
(cl-loop for s in (triples-subjects-of-type ekg-db 'time-tracked) do
         (let ((time-plist (triples-get-type ekg-db s 'time-tracked)))
           (if (and (plist-get time-plist :modified-time)
                    (not (plist-get time-plist :creation-time)))
               (message "Found note missing creation time: %s" s)
             (triples-set-type ekg-db s 'time-tracked
                               :modified-time (plist-get time-plist :modified-time)
                               :creation-time (plist-get time-plist :modified-time)))))

[jayrajput]

Thanks!! On trying this from scratch-buffer, getting this error.

Debugger entered--Lisp error: (error "Triple (2 time-tracked/modified-time nil) has an o...")
  signal(error ("Triple (2 time-tracked/modified-time nil) has an o..."))
  error("Triple %s has an object with the wrong type: expec..." (2 time-tracked/modified-time nil) integer symbol)
  triples-verify-base/type-compliant(integer (2 time-tracked/modified-time nil))
  #f(compiled-function (pred-prop val) #<bytecode -0x752745380b60115>)(:base/type integer)
  triples--plist-mapc(#f(compiled-function (pred-prop val) #<bytecode -0x752745380b60115>) (:base/type integer :base/unique t))
  #f(compiled-function (triple) #<bytecode 0x11a87587c92fbc52>)((2 time-tracked/modified-time nil))
  mapc(#f(compiled-function (triple) #<bytecode 0x11a87587c92fbc52>) ((2 base/type time-tracked) (2 time-tracked/modified-time nil) (2 time-tracked/creation-time nil)))
  triples-verify-schema-compliant(((2 base/type time-tracked) (2 time-tracked/modified-time nil) (2 time-tracked/creation-time nil)) ((time-tracked/modified-time :base/type integer :base/unique t) (time-tracked/creation-time :base/type integer :base/unique t)))
  triples-set-type(#<sqlite db=0x10d5fe850 name=/Users/jr/.emacs.d/triples.db> 2 time-tracked :modified-time nil :creation-time nil)
  (if (and (plist-get time-plist :modified-time) (not (plist-get time-plist :creation-time))) (message "Found note missing creation time: %s" s) (triples-set-type ekg-db s 'time-tracked :modified-time (plist-get time-plist :modified-time) :creation-time (plist-get time-plist :modified-time)))
  (let ((time-plist (triples-get-type ekg-db s 'time-tracked))) (if (and (plist-get time-plist :modified-time) (not (plist-get time-plist :creation-time))) (message "Found note missing creation time: %s" s) (triples-set-type ekg-db s 'time-tracked :modified-time (plist-get time-plist :modified-time) :creation-time (plist-get time-plist :modified-time))))
  (while (consp --cl-var--) (setq s (car --cl-var--)) (let ((time-plist (triples-get-type ekg-db s 'time-tracked))) (if (and (plist-get time-plist :modified-time) (not (plist-get time-plist :creation-time))) (message "Found note missing creation time: %s" s) (triples-set-type ekg-db s 'time-tracked :modified-time (plist-get time-plist :modified-time) :creation-time (plist-get time-plist :modified-time)))) (setq --cl-var-- (cdr --cl-var--)))
  (let* ((--cl-var-- (triples-subjects-of-type ekg-db 'time-tracked)) (s nil)) (while (consp --cl-var--) (setq s (car --cl-var--)) (let ((time-plist (triples-get-type ekg-db s 'time-tracked))) (if (and (plist-get time-plist :modified-time) (not (plist-get time-plist :creation-time))) (message "Found note missing creation time: %s" s) (triples-set-type ekg-db s 'time-tracked :modified-time (plist-get time-plist :modified-time) :creation-time (plist-get time-plist :modified-time)))) (setq --cl-var-- (cdr --cl-var--))) nil)
  (progn (let* ((--cl-var-- (triples-subjects-of-type ekg-db 'time-tracked)) (s nil)) (while (consp --cl-var--) (setq s (car --cl-var--)) (let ((time-plist (triples-get-type ekg-db s 'time-tracked))) (if (and (plist-get time-plist :modified-time) (not (plist-get time-plist :creation-time))) (message "Found note missing creation time: %s" s) (triples-set-type ekg-db s 'time-tracked :modified-time (plist-get time-plist :modified-time) :creation-time (plist-get time-plist :modified-time)))) (setq --cl-var-- (cdr --cl-var--))) nil))
  eval((progn (let* ((--cl-var-- (triples-subjects-of-type ekg-db 'time-tracked)) (s nil)) (while (consp --cl-var--) (setq s (car --cl-var--)) (let ((time-plist (triples-get-type ekg-db s ...))) (if (and (plist-get time-plist :modified-time) (not ...)) (message "Found note missing creation time: %s" s) (triples-set-type ekg-db s 'time-tracked :modified-time (plist-get time-plist :modified-time) :creation-time (plist-get time-plist :modified-time)))) (setq --cl-var-- (cdr --cl-var--))) nil)) t)
  elisp--eval-last-sexp(nil)
  eval-last-sexp(nil)
  funcall-interactively(eval-last-sexp nil)
  call-interactively(eval-last-sexp nil nil)
  command-execute(eval-last-sexp)

[jayrajput]

I have notes which are missing both creation and modification time. Trying to see how to fix them:

Found note missing both modification and creation time: 2b182ba3-ea37-4a0c-af1e-c0ff3c41ee9b
Found note missing both modification and creation time: 2bdaae6e-55c1-4345-b337-6c2a66202a8d
Found note missing both modification and creation time: 2c7cbaac-abc8-4bfd-94a6-c601f4a0c21b
Found note missing both modification and creation time: 3b0a1110-184c-419c-8855-6e634ad4516e
Found note missing both modification and creation time: 4bc08e71-40a3-4fc7-a952-1e59e9bf2ef9
Found note missing both modification and creation time: 5ba018b7-3326-4c06-8151-9eacf46a969d
Found note missing both modification and creation time: 5de62a07-ae20-4a4f-bf67-c6ab9c891fa9
Found note missing both modification and creation time: 8a39e3bd-da04-476d-ae7d-06f4fe233fd8

[jayrajput]

I fixed the notes which were missing both creation-time and modification-time, but that did not helped. I used the below code to update the time to the current-time. I will slow down a little bit for now, before I mess up things more. I do have my old triples.db backup, which I will bring back, once I figured out the right command to fix things.

(cl-loop for s in (triples-subjects-of-type ekg-db 'time-tracked) do
         (let ((time-plist (triples-get-type ekg-db s 'time-tracked)))
           (when (and (not (plist-get time-plist :modified-time))
                    (not (plist-get time-plist :creation-time)))
	     (message "Found note missing both modification and creation time: %s" s)
	     (let ((time (time-convert (current-time) 'integer)))
	       (triples-set-type ekg-db s 'time-tracked
				 :modified-time time
				 :creation-time time)))))

[ahyatt]

When you say it didn't help, do you mean you still have errors loading notes? If so, it must be that there's still some bad data.

[ahyatt]

Sorry for taking a while to respond, I spent yesterday traveling. It looks like we are still setting the modified time and created time to nil. See this line:
triples-set-type(#<sqlite db=0x10d5fe850 name=/Users/jr/.emacs.d/triples.db> 2 time-tracked :modified-time nil :creation-time nil)

It wasn't clear to me if this is the output from my code or yours. Assuming mine, I spent an embarassingly long time looking at my code before I realized that I just wrote if when a when would be appropriate, causing it to execute when it shouldn't.

(cl-loop for s in (triples-subjects-of-type ekg-db 'time-tracked) do
         (let ((time-plist (triples-get-type ekg-db s 'time-tracked)))
           (when (and (plist-get time-plist :modified-time)
                      (not (plist-get time-plist :creation-time)))
               (message "Found note missing creation time: %s" s)
             (triples-set-type ekg-db s 'time-tracked
                               :modified-time (plist-get time-plist :modified-time)
                               :creation-time (plist-get time-plist :modified-time)))))

I noticed you fixed this in your version, so I think your version should really work. However, you are saying even after executing your version, you still see problematic entries. Can you run the following on your db?

SELECT COUNT(DISTINCT t1.subject)
FROM triples t1
LEFT JOIN triples t2 ON t1.subject = t2.subject AND t2.object = 'time-tracked'
WHERE t1.predicate = 'time-tracked/modified-time' AND t2.subject IS NULL 
OR t1.predicate = 'time-tracked/creation-time' and t2.subject IS NULL;

That should tell us how many of these bad notes exist.

[jayrajput]

[jayrajput]

Note with missing creation time.

33542768887

[jayrajput]

I re-ran your code with when and it worked (atleast my code is past the creation-time problem). I will keep this thread open if I find anything else, but I think I am good. Thanks.

(cl-loop for s in (triples-subjects-of-type ekg-db 'time-tracked) do
         (let ((time-plist (triples-get-type ekg-db s 'time-tracked)))
           (when (and (plist-get time-plist :modified-time)
                    (not (plist-get time-plist :creation-time)))
               (message "Found note missing creation time: %s" s)
             (triples-set-type ekg-db s 'time-tracked
                               :modified-time (plist-get time-plist :modified-time)
                               :creation-time (plist-get time-plist :modified-time)))))

[jayrajput]

Note that the code is not indented triples-set-type shall be aligned with the message.