diff --git a/karma.conf.js b/karma.conf.js index b80efa5..f6460c6 100644 --- a/karma.conf.js +++ b/karma.conf.js @@ -2,7 +2,7 @@ // Generated on Wed Jun 18 2014 09:33:44 GMT+0100 (BST) module.exports = function(config) { - var browsers = ['PhantomJS', 'Firefox']; + var browsers = ['Firefox']; if (!process.TRAVIS) { browsers.push('Chrome'); diff --git a/package.json b/package.json index 7d46b91..602d022 100644 --- a/package.json +++ b/package.json @@ -26,12 +26,12 @@ }, "homepage": "https://github.com/ahmednuaman/javascript-tests", "dependencies": { - "karma": "^0.12.32", - "karma-jasmine": "^0.3.5", - "karma-phantomjs-launcher": "^0.1.4" + "karma-jasmine": "^4.0.1", + "karma-phantomjs-launcher": "^1.0.4", + "karma": "^6.3.2" }, "devDependencies": { - "karma-chrome-launcher": "^0.1.12", - "karma-firefox-launcher": "^0.1.6" + "karma-chrome-launcher": "^3.1.0", + "karma-firefox-launcher": "^2.1.0" } } diff --git a/test/clone-object.js b/test/clone-object.js index 86ec647..596efc7 100644 --- a/test/clone-object.js +++ b/test/clone-object.js @@ -1,8 +1,8 @@ describe('clone object', function () { it('should clone an object', function () { var expected = {name: 'Ahmed', age: 27, skills: ['cycling', 'walking', 'eating']}, - obj = {}; - + obj = {...expected}; + expect(obj).toEqual(expected); expect(obj).not.toBe(expected); }); diff --git a/test/flatten-array.js b/test/flatten-array.js index c7f0632..e6daaf8 100644 --- a/test/flatten-array.js +++ b/test/flatten-array.js @@ -2,7 +2,21 @@ describe('flatten array', function () { it('should flatten an array', function () { var arr = [1, 2, [1, 2, [3, 4, 5, [1]]], 2, [2]], expected = [1, 1, 1, 2, 2, 2, 2, 3, 4, 5]; - + + const flattenArray = (arr) => { + someNewArray = arr.reduce((acc, item)=>{ + if(Array.isArray(item)){ + acc = acc.concat(flattenArray(item)) + } + else{ + acc = [...acc, item] + } + return acc + },[]) + return someNewArray.sort() + } + + arr = flattenArray(arr) expect(arr).toEqual(expected); }); }); \ No newline at end of file diff --git a/test/scoping.js b/test/scoping.js index 557c54a..92c32e3 100644 --- a/test/scoping.js +++ b/test/scoping.js @@ -16,7 +16,7 @@ describe('scoping', function () { }; Module.prototype.req = function() { - return request(this.method); + return request(this.method.bind(this)); }; expect(mod.req()).toBe('bar');