From 068ce32a8bef6260560ac89601604f55ca737c41 Mon Sep 17 00:00:00 2001 From: Bert Scholten Date: Mon, 7 Apr 2025 12:10:22 +0200 Subject: [PATCH 1/2] Fail build when unittests fail for PRs Be more strict on failing tests for PRs, to avoid missing a failing test before merging. --- .../workflows/on-pull_request-opened-synchronize-reopened.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/on-pull_request-opened-synchronize-reopened.yml b/.github/workflows/on-pull_request-opened-synchronize-reopened.yml index a2d509b..9b18e23 100644 --- a/.github/workflows/on-pull_request-opened-synchronize-reopened.yml +++ b/.github/workflows/on-pull_request-opened-synchronize-reopened.yml @@ -19,6 +19,7 @@ jobs: - uses: aerius/github-actions/events/pull_request-event-action@v1.1 with: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + IGNORE_TEST_FAILURES: false - uses: aerius/github-actions/extras/docker-build-action@v1.1 with: From 9686a7e4ea5333eac383705f319251d243cb507e Mon Sep 17 00:00:00 2001 From: Bert Scholten Date: Mon, 7 Apr 2025 12:29:42 +0200 Subject: [PATCH 2/2] Include all relevant modules to publish profile Not sure what the idea was behind not publishing the service and its dependencies, but it's causing the code not to be compiled/tested when building the PR. And these should be published to nexus anyway I think? --- pom.xml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pom.xml b/pom.xml index 25c5e3f..2b4ab0e 100644 --- a/pom.xml +++ b/pom.xml @@ -194,6 +194,12 @@ publish + search-service + search-service-extension + search-service-geo + search-service-pdok-locatieservice + search-service-bing-geocoder + search-service-n2000-assessment-areas-nl search-shared search-client